-
-
Notifications
You must be signed in to change notification settings - Fork 722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some new options to distinguish date and title, +American spelling of color #105
Open
Olliebrown
wants to merge
39
commits into
acaudwell:master
Choose a base branch
from
Olliebrown:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- New CL option to set title size/color separate from date - New CL option to swap position of date and title - Tweaked the y position calc of top-center/bottom-left text - New CL options to adjust y position of date or title Changes to be committed: modified: src/gource.cpp modified: src/gource.h modified: src/gource_settings.cpp modified: src/gource_settings.h
Unfortunately on further testing with GLM 0.9.9 (which is in alpha) it was found to be unstable due to a change to the library removing default constructors of vectors, resulting in uninitialized values being used. The current release of GLM 0.9.8 is fine.
…ved). The current GLM 0.9.9 pre-release alpha contains a change removing the default initialization of vectors with no way of getting the old behavior. This issue is compounded by Debian (and now Ubuntu) packaging this version of GLM despite it being an alpha and not backwards compatible. I expect a lot of other software will be affected by this decision as well. For the time being I have decided to use a fixed version of GLM 0.9.8.5 including a fix to compile with minor versions of GCC >= 7.3 which has not been included in an official release yet.
Add src/core/glm to tarball.
This is significant for tools like doclifter that lift to XML/HTML.
After the first commit in a log is read to check the file format the log it is rewound to the beginning, however the last line read was still buffered so it would return the buffered line next not the first line of the log. As custom log entries are all on one line this would erroneously be parsed as the first commit.
Enabling this option causes gource to use the time of the parent commit, if the time of a commit is in the past. This allows a linear simulation, even if the time of the commits are not corresponding to the order of the commits.
When the commit queue is empty lasttime use lasttime instead of currtime to determine if the commit time is out of order as currtime is incremented by the simulation.
Using this option allows to move the directory name to the root (0.0) or to the leafs (1.0).
Renamed midpoint to label_pos.
Enabling this option causes gource to use the filename as the file extension if no extension is set or the filename ends with a dot. As a result every file without an extension has an own entry in the file extension key.
While parsing a commit when the parser encountered the first line of the next commit it would buffer it to be parsed next, however it didn't use the correct method to then fetch the next line so the buffered entry was missed.
…tamp. Thanks to Lars Schmertmann for helping debug this issue.
- New CL option to set title size/color separate from date - New CL option to swap position of date and title - Tweaked the y position calc of top-center/bottom-left text - New CL options to adjust y position of date or title Changes to be committed: modified: src/gource.cpp modified: src/gource.h modified: src/gource_settings.cpp modified: src/gource_settings.h
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added some options for myself to customize the date and title independently and to swap their positions. Also tried to get them to compute a better y position but it's still not perfect so added CL options to fudge the final value. Lastly, added some aliases for command line options using American spelling of color.