Fix some warnings identified by a static analyzer #2486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code was using the reload variable as an indicator that prev_global_data was not NULL, and this was causing some static code analysers to to flag up NULL pointer dereferences. The patch explicitly checks whether prev_global_data is NULL or not, since this is synonymous with testing the reload variable. Signed-off-by: Quentin Armitage <[email protected]>
The code was, in some places, also setting dbus_{in,out}_pipe[1]
to -1 when it closed the pipes, which is unnecessary. In other places
it set dbus_{in,out}_pipe[0] to -1 twice, and did not set the [1]
equivalents at all, which was just wrong.
Signed-off-by: Quentin Armitage <[email protected]>
This means that if that if there is a subsequent reference to the
old data via thoe old_global_data, or old{bfd,check,vrrp} pointers,
it should cause a segfault rather than undefined behaviour. It will
also make it more straightford to debug any problem should it occur.
Signed-off-by: Quentin Armitage <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although none of the warnings was due to any error in the code that could cause a problem. for some of the warnings reported is was quite straightforward to modify the code in a way that was just as readable and would avoid the warnings.
Two of the warnings reported could not possibly result in an error, and checks (return code or null dereferences) were not made since the design of the code was such that they could not occur.