feat(chore): add test execution #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pallendes
reviewed
Sep 22, 2023
src/components/alert/alert.test.tsx
Outdated
| describe("Alert", () => { | ||
| it("renders an alert with a title and children", () => { | ||
| // ARRANGE | ||
| const { getByRole } = render( |
There was a problem hiding this comment.
Using screen.getByRole is recommended by the creators, although it doesn't make a substantial difference 😄
There was a problem hiding this comment.
I will change it to match the docs! Thanks for bringing that up. I run through different examples to get the additional "toBeInTheDocument()" functions to work and I guess I messed it up.
.github/workflows/test.yaml
Outdated
| steps: | ||
| - uses: actions/checkout@v3 | ||
| with: | ||
| persist-credentials: false # <--- this |
There was a problem hiding this comment.
What does that comment mean 🤔 ?
There was a problem hiding this comment.
tbh I copied it from all other actions. I will remove it for all of them 👍🏻
mnlfischer
deleted the
pla-479-hailstorm-setup-test-execution-for-repo
branch
|
🎉 This PR is included in version 2.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding Vitest and a new action for automated testing. This PR only adds one component test for testing reasons.
Checklist