Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pla 1302 upgrade hailstorm to headlessui v2 #138

Merged
merged 43 commits into from
Aug 1, 2024

Conversation

mnlfischer
Copy link
Contributor

Description

We update HeadlessUi to the latest major version. This PR changes deprecated implementation of components and adds consistent naming of imports from HeadlessUi.

The deprecated way of styling is still supported. Another PR will also update the styling to data-* attributes.

@mnlfischer mnlfischer requested a review from Coderwelsch July 31, 2024 12:07
@mnlfischer mnlfischer self-assigned this Jul 31, 2024
Copy link

linear bot commented Jul 31, 2024

@mnlfischer mnlfischer changed the title Pla 1302 upgrade hailstorm to headlessui v2 Draft: Pla 1302 upgrade hailstorm to headlessui v2 Jul 31, 2024
@mnlfischer mnlfischer removed the request for review from Coderwelsch July 31, 2024 12:08
@mnlfischer mnlfischer requested a review from Coderwelsch July 31, 2024 12:15
@mnlfischer mnlfischer changed the title Draft: Pla 1302 upgrade hailstorm to headlessui v2 Pla 1302 upgrade hailstorm to headlessui v2 Jul 31, 2024
Copy link
Contributor

@Coderwelsch Coderwelsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Crazy Upgrade 🔥 ^^

@@ -10,11 +10,10 @@ export interface RadioBoxOptionProps {
}

const radioBoxContainerStyles = {
base: "group relative flex items-center gap-3 rounded-lg bg-neutral-0 border p-4 border-neutral-300 hover:border-primary-600 hover:bg-primary-50 cursor-pointer focus:outline-none",
base: "group relative flex items-center gap-3 rounded-lg bg-neutral-0 border p-4 border-neutral-300 hover:border-primary-600 hover:bg-primary-50 cursor-pointer focus:outline-none data-[focus]:outline-2 data-[focus]:outline-primary-200",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That data-focus thing is interesting 🍿

@mnlfischer mnlfischer merged commit 985bbe6 into main Aug 1, 2024
6 checks passed
@mnlfischer mnlfischer deleted the pla-1302-upgrade-hailstorm-to-headlessui-v2 branch August 1, 2024 07:24
@abusix-bot
Copy link
Collaborator

🎉 This PR is included in version 5.6.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants