Use stringer

internal/ipc/ipc.go

@@ -10,6 +10,7 @@ import (
 
 const SocketAddr = "/tmp/baxs.sock"
 
+//go:generate stringer -type=Op
 type Op uint8
 
 const (
@@ -18,19 +19,6 @@ const (
 	OpStart
 )
 
-func (op Op) String() string {
-	switch op {
-	case OpPs:
-		return "ps"
-	case OpStop:
-		return "stop"
-	case OpStart:
-		return "start"
-	default:
-		return "unknown"
-	}
-}
-
 type Request struct {
 	Stop  *StopInput  `json:",omitempty"`
 	Start *StartInput `json:",omitempty"`

internal/ipc/ipc_test.go

@@ -155,25 +155,6 @@ func TestStart(t *testing.T) {
 	}
 }
 
-func TestOp(t *testing.T) {
-	tests := []struct {
-		name string
-		op   Op
-	}{
-		{"ps", OpPs},
-		{"start", OpStart},
-		{"stop", OpStop},
-		{"unknown", Op(255)},
-	}
-	for _, test := range tests {
-		t.Run(test.name, func(t *testing.T) {
-			if v := test.op.String(); v != test.name {
-				t.Fatalf("expected %s, have %s", test.name, v)
-			}
-		})
-	}
-}
-
 func TestWire(t *testing.T) {
 	t.Run("EmptyRequest", func(t *testing.T) {
 		var r Request

internal/process/process.go

@@ -13,6 +13,7 @@ import (
 	"bandr.me/p/baxs/internal/ipc"
 )
 
+//go:generate stringer -type=State
 type State uint8
 
 const (
@@ -23,23 +24,6 @@ const (
 	Finished
 )
 
-func (s State) String() string {
-	switch s {
-	case Idle:
-		return "idle"
-	case Failed:
-		return "failed"
-	case Running:
-		return "running"
-	case Stopped:
-		return "stopped"
-	case Finished:
-		return "finished"
-	default:
-		return fmt.Sprintf("invalid state: %d", s)
-	}
-}
-
 type Process struct {
 	Cmd     *exec.Cmd
 	Name    string

makefile

@@ -2,7 +2,10 @@ dev: clean build vet lint test
 
 ci: clean build vet test
 
-build:
+generate:
+	go generate ./...
+
+build: generate
 	CGO_ENABLED=0 go build
 
 vet:
@@ -31,3 +34,6 @@ fuzz:
 release: dev clean
 	CGO_ENABLED=0 go build -ldflags "-s -w"
 	strip -s baxs
+
+misc:
+	go install golang.org/x/tools/cmd/stringer@latest