NOISSUE - Fix invalid chart directory in lint-test.yaml
#156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeffMboya
changed the title
lint-test.yamllint-test.yaml
Signed-off-by: JeffMboya <[email protected]> Update README Signed-off-by: JeffMboya <[email protected]> increment chart version Signed-off-by: JeffMboya <[email protected]> Fix CI Signed-off-by: JeffMboya <[email protected]> Fix CI Signed-off-by: JeffMboya <[email protected]> increase timeout Signed-off-by: JeffMboya <[email protected]> remove extra space Signed-off-by: JeffMboya <[email protected]> Add debug statements Signed-off-by: JeffMboya <[email protected]> Add debug statements Signed-off-by: JeffMboya <[email protected]> reduce resource constraints Signed-off-by: JeffMboya <[email protected]> Fix linter Signed-off-by: JeffMboya <[email protected]> Fix linter Signed-off-by: JeffMboya <[email protected]>
arvindh123
requested changes
Oct 8, 2024
Comment on lines
+102
to
+103
| | jaeger.collector.service.otlp.grpc.name | string | `"otlp-grpc"` | | | ||
| | jaeger.collector.service.otlp.grpc.port | int | `4317` | | |
There was a problem hiding this comment.
@JeffMboya Why do we need this values ?
Just asking to know the usage of values
There was a problem hiding this comment.
@arvindh123 They ensure that Jaeger is ready to receive and process data over the gRPC protocol
arvindh123
approved these changes
Oct 8, 2024
dborovcanin
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
This pull request fixes the issue where the provided chart directory was not being detected as a valid Helm chart directory during the
ct lintstep in the GitHub CI workflow.Which issue(s) does this PR fix/relate to?
None
List any changes that modify/break current functionality
None
Have you included tests for your changes?
No
Did you document any new/modified functionality?
No
Notes
This is the received logs from the CI
Run ct lint --target-branch main --chart-dirs charts/magistrala/ Linting charts... >>> helm version --template {{ .Version }} >>> git rev-parse --is-inside-work-tree >>> git rev-parse --verify origin/main >>> git merge-base origin/main HEAD >>> git diff --find-renames --name-only 277fe28b0343dafe56e8be88a69f5c8eec649e[18](https://github.com/absmach/magistrala/actions/runs/11127502755/job/30919951217?pr=103#step:9:19) -- charts/magistrala/ Directory "charts/magistrala" is not a valid chart directory. Skipping... Directory "charts/magistrala" is not a valid chart directory. Skipping... Directory "charts/magistrala" is not a valid chart directory. Skipping... Directory "charts/magistrala" is not a valid chart directory. Skipping... Directory "charts/magistrala" is not a valid chart directory. Skipping... Directory "charts/magistrala/charts" is not a valid chart directory. Skipping... Directory "charts/magistrala/templates" is not a valid chart directory. Skipping... Directory "charts/magistrala/templates" is not a valid chart directory. Skipping... Directory "charts/magistrala/templates" is not a valid chart directory. Skipping... Directory "charts/magistrala/templates" is not a valid chart directory. Skipping... Directory "charts/magistrala/templates" is not a valid chart directory. Skipping... Directory "charts/magistrala/templates" is not a valid chart directory. Skipping... Directory "charts/magistrala" is not a valid chart directory. Skipping... ------------------------------------------------------------------------------------------------------------------------ No chart changes detected. ------------------------------------------------------------------------------------------------------------------------ All charts linted successfullyThis is the expected logs from the CI