Bump apps version in GitHub CI #166
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
List of changes: - bump actions/checkout to v4 - remove unused deps - support Erlang/OTP 26.x and Elixir 1.15.x - update docker command to work with podman - use default naming of jobs to show `lint` flag
kianmeng
commented
Nov 13, 2023
| @@ -17,7 +17,7 @@ Make sure the tests pass. | |||
|
|
|||
| Running tests for Dataloader requires a running instance of Postgres. The easiest way to do this is to run Postgres inside of Docker whilst running the Dataloader tests. In one terminal run: | |||
|
|
|||
| docker run -p 5432:5432 -e POSTGRES_PASSWORD=postgres -e POSTGRES_DB=dataloader_test postgres | |||
| docker run -p 5432:5432 -e POSTGRES_PASSWORD=postgres -e POSTGRES_DB=dataloader_test docker.io/postgres | |||
There was a problem hiding this comment.
$ docker run -p 5432:5432 -e POSTGRES_PASSWORD=postgres -e POSTGRES_DB=dataloader_test postgres
Emulate Docker CLI using podman. Create /etc/containers/nodocker to quiet msg.
Error: short-name "postgres" did not resolve to an alias and no unqualified-search registries are defined in "/etc/containers/registries.conf"
kianmeng
commented
Nov 13, 2023
| @@ -394,13 +394,13 @@ defmodule Dataloader do | |||
| # Optionally use `async/1` and `async_stream/3` functions from | |||
| # `opentelemetry_process_propagator` if available | |||
| if Code.ensure_loaded?(OpentelemetryProcessPropagator.Task) do | |||
| @spec async((() -> any)) :: Task.t() | |||
| @spec async((-> any)) :: Task.t() | |||
There was a problem hiding this comment.
Run mix format --check-formatted
** (Mix) mix format failed due to --check-formatted.
The following files are not formatted:
/home/runner/work/dataloader/dataloader/lib/dataloader.ex
kianmeng
commented
Nov 13, 2023
| @@ -8,7 +8,7 @@ defmodule Dataloader.Mixfile do | |||
| [ | |||
| app: :dataloader, | |||
| version: @version, | |||
| elixir: "~> 1.12", | |||
| elixir: "~> 1.11", | |||
There was a problem hiding this comment.
Right now, the minimum supported Elixir version with security patches is 1.11, see https://hexdocs.pm/elixir/1.15.7/compatibility-and-deprecations.html
kianmeng
commented
Nov 13, 2023
|
|
||
| - name: Check unused deps | ||
| run: mix deps.unlock --check-unused | ||
| if: ${{ matrix.lint }} |
There was a problem hiding this comment.
Run mix deps.unlock --check-unused
** (Mix) Unused dependencies in mix.lock file:
* :connection
Error: Process completed with exit code 1.
kianmeng
commented
Nov 13, 2023
| @@ -8,8 +8,7 @@ on: | |||
|
|
|||
| jobs: | |||
| test: | |||
| name: Elixir ${{matrix.elixir}} / OTP ${{matrix.otp}} | |||
There was a problem hiding this comment.
We want to show the lint flag in job name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List of changes:
lintflag