Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subscription broker #274

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

maartenvanvliet
Copy link
Contributor

Previously subscriptions over HTTP were handled through SSE.
This commits adds a callback so the user can choose to handle it
differently. It's modelled after how graphl-ruby
does it.

I think this gives the flexibility to the user to implement
their own subscription broker implementation. It gives access to the
http request to be changed in a way the user sees fit.
There's still some work to be done on the Absinthe side for a user,
though this can be done in userland by replacing some phases.

absinthe_phoenix could use a similar callback.

See #217 for
previous work.

Previously subscriptions over HTTP were handled through SSE.
This commits adds a callback so the user can choose to handle it
differently. It's modelled after how [graphl-ruby](https://graphql-ruby.org/subscriptions/pusher_implementation.html)
does it.

I think this gives the flexibility to the user to implement
their own subscription broker implementation. It gives access to the
http request to be changed in a way the user sees fit.
There's still some work to be done on the Absinthe side for a user,
though this can be done in userland by replacing some phases.

`absinthe_phoenix` could use a similar callback.

See absinthe-graphql#217 for
previous work.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant