Skip to content

Commit

Permalink
use a more compact initial phases approach
Browse files Browse the repository at this point in the history
  • Loading branch information
benwilson512 committed Aug 15, 2023
1 parent f3dfc72 commit 4e162d6
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 5 deletions.
14 changes: 11 additions & 3 deletions lib/absinthe/phoenix/channel.ex
Original file line number Diff line number Diff line change
Expand Up @@ -117,10 +117,18 @@ defmodule Absinthe.Phoenix.Channel do
end
end

defp run(document, schema, pipeline, options) do
{module, fun} = pipeline
defp run(document, schema, pipeline_mf, options) do
{module, fun} = pipeline_mf
args = [schema, options]

case Absinthe.Pipeline.run(document, apply(module, fun, [schema, options])) do
blueprint = %Absinthe.Blueprint{input: document, initial_phases: {module, fun, args}}

pipeline =
module
|> apply(fun, args)
|> Absinthe.Pipeline.without(Absinthe.Phase.Init)

case Absinthe.Pipeline.run(blueprint, pipeline) do
{:ok, %{result: result, execution: res}, _phases} ->
{:ok, result, res.context}

Expand Down
2 changes: 1 addition & 1 deletion mix.exs
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ defmodule Absinthe.Phoenix.Mixfile do
defp deps do
[
{:absinthe_plug, "~> 1.5"},
{:absinthe, "~> 1.5"},
{:absinthe, "~> 1.5", github: "absinthe-graphql/absinthe", branch: "initial-phases-mfa", override: true},
{:decimal, "~> 1.0 or ~> 2.0"},
{:phoenix, "~> 1.5"},
{:phoenix_pubsub, "~> 2.0"},
Expand Down
2 changes: 1 addition & 1 deletion mix.lock
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
%{
"absinthe": {:hex, :absinthe, "1.7.5", "a15054f05738e766f7cc7fd352887dfd5e61cec371fb4741cca37c3359ff74ac", [:mix], [{:dataloader, "~> 1.0.0 or ~> 2.0", [hex: :dataloader, repo: "hexpm", optional: true]}, {:decimal, "~> 1.0 or ~> 2.0", [hex: :decimal, repo: "hexpm", optional: true]}, {:nimble_parsec, "~> 1.2.2 or ~> 1.3.0", [hex: :nimble_parsec, repo: "hexpm", optional: false]}, {:opentelemetry_process_propagator, "~> 0.2.1", [hex: :opentelemetry_process_propagator, repo: "hexpm", optional: true]}, {:telemetry, "~> 0.4 or ~> 1.0", [hex: :telemetry, repo: "hexpm", optional: false]}], "hexpm", "22a9a38adca26294ad0ee91226168f5d215b401efd770b8a1b8fd9c9b21ec316"},
"absinthe": {:git, "https://github.com/absinthe-graphql/absinthe.git", "20932b06663d826a0e7627eee866cf190e017211", [branch: "initial-phases-mfa"]},
"absinthe_plug": {:hex, :absinthe_plug, "1.5.8", "38d230641ba9dca8f72f1fed2dfc8abd53b3907d1996363da32434ab6ee5d6ab", [:mix], [{:absinthe, "~> 1.5", [hex: :absinthe, repo: "hexpm", optional: false]}, {:plug, "~> 1.4", [hex: :plug, repo: "hexpm", optional: false]}], "hexpm", "bbb04176647b735828861e7b2705465e53e2cf54ccf5a73ddd1ebd855f996e5a"},
"castore": {:hex, :castore, "1.0.3", "7130ba6d24c8424014194676d608cb989f62ef8039efd50ff4b3f33286d06db8", [:mix], [], "hexpm", "680ab01ef5d15b161ed6a95449fac5c6b8f60055677a8e79acf01b27baa4390b"},
"decimal": {:hex, :decimal, "2.1.1", "5611dca5d4b2c3dd497dec8f68751f1f1a54755e8ed2a966c2633cf885973ad6", [:mix], [], "hexpm", "53cfe5f497ed0e7771ae1a475575603d77425099ba5faef9394932b35020ffcc"},
Expand Down

0 comments on commit 4e162d6

Please sign in to comment.