Fix default_value error on enum type #1118
Open
+16
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hey @benwilson512 any thoughts on this one? |
|
I just wanted to bump this as I stumbled upon the bug it solves today. The fix looks correct to me. I'd be happy to help if there's something more required to get this merged. |
|
Would love to see this merged in. 🙏 |
|
Bumping this as well. Tagging @benwilson512 again, this seems like a quick merge |
|
Hey @benwilson512 Do you think we could go with this approach or suggest anything else? This issue blocked us from upgrading absinthe for a long time. |
|
We came to another workaround that removing default value from enum params. Default value is checked and filled by resolver. It's a bit more code but unblock upgrading. |
|
@benwilson512 please, review this PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, this PR aiming to fix the issue #1081 for the time being before we could come up with anything better.
Currently i'm trying to understand how notation and schema work so i tried my best at fixing the validation which is desirable for the time being since we are having troubles trying to upgrade our absinthe from 1.5.5 to 1.6.6. This issue caused everything to explode ( we indeed used alot of default value).
Any guidances would be appreciated!