-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated version of gms module (includes #40 and #47) #50
base: master
Are you sure you want to change the base?
Conversation
replace / by %2F in project stored on sub-sub-group
- Set default Puppet version to 5.5.0 - Updated dependencies in metadata.json to more modern versions Note: not switching to Puppet6 yet. It probably will work, but I'm not testing too much with Puppet6 myself.
In Travis, don't test old Puppet with new Ruby versions.
- Deleted some non-supported combinations of Puppet and Ruby from Travis Matrix - Added some form of matrix for Gitlab CI - Gitlab CI fixes for old Puppet versions
+1 to moving this to the community. This is a very helpful module and I think it's important to have reliable way to make future updates and merges. |
@abrader Is there anything we can help you with getting a new version of this module published on the Puppet forge? |
Any chance of getting this merged? |
My apologies on the delay of this reply. If this is still of interest to you, please let me know. |
Based on my knowledge and issues encountered in the past, this module needs to be API version aware so it can be used with newer versions of the GitLab API... |
I'm stiil using this module in combination with Gitlab today. I've upgraded to just about every Gitlab release that came out while this PR was open, and do not recall any issues. At the moment I only use the git_deploy_key type, but have also used git_webhook in the past. The only thing I'd like to add to my PR right now is to increase the dependencies on Puppet version and stdlib version. The latter one also means dropping support for Puppet < 5.5. Any thoughts on that? |
I can confirm that this fix works for RHEL7 and RHEL8 on Puppet Server 7.6.0 and newer. Can we please get a merge? |
@bschonec it looks like @abrader isn't really active on Github anymore? I don't know if anyone else has the rights to do merges on this repository. Alternatively, someone should fork this module and push that to the Puppet Forge. I do still use this module, but am not involved enough with it to be the best candidate for such a fork right now. Maybe @voxpupuli can help? |
I sent an email to abraders' address but he has not replied. |
PS. Please consider migrating this module to VoxPupuli (#46)...