Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rockylinux advisories #1535

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

ambuj-1211
Copy link
Collaborator

fixes: #753

@ambuj-1211
Copy link
Collaborator Author

@ziadhany please review this pr, I have added the Rockylinux importer and tests for it.

@ziadhany ziadhany self-requested a review August 5, 2024 14:23
Copy link
Collaborator

@ziadhany ziadhany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ambuj-1211, please see few nits below for your consideration

vulnerabilities/importers/rockylinux.py Outdated Show resolved Hide resolved
vulnerabilities/importers/rockylinux.py Outdated Show resolved Hide resolved
vulnerabilities/importers/rockylinux.py Outdated Show resolved Hide resolved
vulnerabilities/importers/rockylinux.py Outdated Show resolved Hide resolved
vulnerabilities/importers/rockylinux.py Outdated Show resolved Hide resolved
- Modified the severity score collection.
- Refined docstrings
Signed-off-by: ambuj <[email protected]>
Copy link
Collaborator

@ziadhany ziadhany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ambuj-1211 Thank you! Please use the new pipeline and resolve the severity and reference issues, run the importer and print the logs.

vulnerabilities/importers/rockylinux.py Outdated Show resolved Hide resolved
vulnerabilities/importers/rockylinux.py Outdated Show resolved Hide resolved
vulnerabilities/importers/rockylinux.py Outdated Show resolved Hide resolved
vulnerabilities/importers/rockylinux.py Outdated Show resolved Hide resolved
@TG1999 TG1999 added this to the v36.0.0 - 3-next milestone Oct 15, 2024
@ambuj-1211
Copy link
Collaborator Author

@ziadhany I have made the changes and created the rockylinux pipeline code, here are the logs for it.
rockylinux_importer_pipeline_logs.txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Collect rockylinux advisories
3 participants