-
-
Notifications
You must be signed in to change notification settings - Fork 551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add handler for packages.lock.json in nuget #3825
Conversation
Signed-off-by: Tushar Goel <[email protected]>
Signed-off-by: Tushar Goel <[email protected]>
Signed-off-by: Tushar Goel <[email protected]>
Signed-off-by: Tushar Goel <[email protected]>
Signed-off-by: Tushar Goel <[email protected]>
Signed-off-by: Tushar Goel <[email protected]>
Signed-off-by: Tushar Goel <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks++ @TG1999
See comments for a few questions and changes.
Also, typically we have lockfiles beside another package manifest right?
I was looking for examples of this and is this .csproj
files for nuget? Are there other manifests which would be nice to parse and store?
Here is an example of a .csproj
file and packages.lock.json
together: https://github.com/ncblakely/GiantsTools/tree/main/Giants.Services to add as tests.
Should we not also do some lightweight package assembly here?
Signed-off-by: Tushar Goel <[email protected]>
Signed-off-by: Tushar Goel <[email protected]>
Signed-off-by: Tushar Goel <[email protected]>
Adressed all review comments, feel free to merge. |
Signed-off-by: Tushar Goel <[email protected]>
Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thanks++ @TG1999 merging!
Reference: aboutcode-org/scancode.io#1263
Tasks
Run tests locally to check for errors.