Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add handler for packages.lock.json in nuget #3825

Merged
merged 12 commits into from
Jun 26, 2024

Conversation

TG1999
Copy link
Contributor

@TG1999 TG1999 commented Jun 24, 2024

Reference: aboutcode-org/scancode.io#1263

Tasks

  • Reviewed contribution guidelines
  • PR is descriptively titled 📑 and links the original issue above 🔗
  • Tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR
    Run tests locally to check for errors.
  • Commits are in uniquely-named feature branch and has no merge conflicts 📁
  • Updated documentation pages (if applicable)
  • Updated CHANGELOG.rst (if applicable)

Copy link
Member

@AyanSinhaMahapatra AyanSinhaMahapatra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks++ @TG1999

See comments for a few questions and changes.

Also, typically we have lockfiles beside another package manifest right?
I was looking for examples of this and is this .csproj files for nuget? Are there other manifests which would be nice to parse and store?
Here is an example of a .csproj file and packages.lock.json together: https://github.com/ncblakely/GiantsTools/tree/main/Giants.Services to add as tests.
Should we not also do some lightweight package assembly here?

src/packagedcode/nuget.py Outdated Show resolved Hide resolved
src/packagedcode/nuget.py Outdated Show resolved Hide resolved
src/packagedcode/nuget.py Outdated Show resolved Hide resolved
src/packagedcode/nuget.py Outdated Show resolved Hide resolved
src/packagedcode/nuget.py Outdated Show resolved Hide resolved
src/packagedcode/nuget.py Outdated Show resolved Hide resolved
tests/packagedcode/data/nuget/packages.lock.json.expected Outdated Show resolved Hide resolved
src/packagedcode/nuget.py Outdated Show resolved Hide resolved
Signed-off-by: Tushar Goel <[email protected]>
Signed-off-by: Tushar Goel <[email protected]>
Signed-off-by: Tushar Goel <[email protected]>
@TG1999
Copy link
Contributor Author

TG1999 commented Jun 25, 2024

Adressed all review comments, feel free to merge.

TG1999 and others added 2 commits June 26, 2024 13:34
Signed-off-by: Tushar Goel <[email protected]>
Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
Copy link
Member

@AyanSinhaMahapatra AyanSinhaMahapatra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thanks++ @TG1999 merging!

@AyanSinhaMahapatra AyanSinhaMahapatra merged commit e4f6267 into develop Jun 26, 2024
5 of 33 checks passed
@AyanSinhaMahapatra AyanSinhaMahapatra deleted the add_nuget_lockfile_handler branch June 26, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants