Add upload component #316
Add upload component #316
Conversation
|
Preview link: https://316.react-ui.aboutbits.dev |
| fileUploadObject: FileUploadObject<CustomRemoteFile>, | ||
| ) => { | ||
| setIsDeleting(true) | ||
| await axiosInstance.post('/delete') |
There was a problem hiding this comment.
We should add a try/catch here to have a good example code.
There was a problem hiding this comment.
What should be in the catch in that case?
There was a problem hiding this comment.
Good question. We could just ignore it in this example and add a comment Handle error accordingly or something. Wdyt?
src/components/files/index.tsx
Outdated
There was a problem hiding this comment.
Don't forget to export the actions
There was a problem hiding this comment.
Currently we don't have any icons in this lib. I see the following possibilities for this:
- Keep it for internal use only (no export)
- Export it as component for projects
- Remove it and require the user to set a custom
spinnerIconprop where needed. - Do not use a custom animated icon, but use the Progress Activity icon from our icon lib and rotate it.
Maybe option 4 is the most consistend, otherwise I would go with option 2.
Wdyt @alexlanz?
There was a problem hiding this comment.
You mean that we do not have any custom icons in ReactUI, but we are using our Material Icons package right?
Allowing to add a custom spinner icon is a bit of an overkill or not? I would try to go with option 4, because then we stick to the same icons that we already use and the animation could be done with only CSS.
What do you both think?
There was a problem hiding this comment.
For me, option 4 sounds also good
There was a problem hiding this comment.
There's one too many tsx's in that filename ;)
No description provided.