Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

select-item-form-field-v2 #312

Closed
wants to merge 1 commit into from
Closed

select-item-form-field-v2 #312

wants to merge 1 commit into from

Conversation

lukasvice
Copy link
Contributor

This is a new version of the `SelectItemFormField' that works with a complex object as form value.

@lukasvice lukasvice self-assigned this Apr 30, 2024
@github-actions GitHub Actions
Copy link

Preview link: https://312.react-ui.aboutbits.dev

alexlanz
alexlanz approved these changes May 2, 2024
View reviewed changes
Copy link
Member

@alexlanz alexlanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Let's see after the first integration test if we keep the name suffix V2 or if we remove the old component.

@mmalfertheiner
Copy link
Member

@lukasvice should we close this PR due to our last discussions?

@lukasvice
Copy link
Contributor Author

Yes, let's close it. I'll open a ticket in Linear and reference this PR in case we need it again.

@lukasvice lukasvice closed this May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexlanz alexlanz alexlanz approved these changes

@mmalfertheiner mmalfertheiner Awaiting requested review from mmalfertheiner

Assignees

@lukasvice lukasvice

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lukasvice @mmalfertheiner @alexlanz