New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make confirmation-dialog dismissable by keyboard #306

Merged

lukasvice merged 1 commit into main from dismiss-confirmation-dialog

Jan 9, 2024

Contributor

lukasvice commented Jan 9, 2024

I think it makes sense that a ConfirmationDialog can be dismissed by pressing ESC or by clicking on the dialog overlay.


          make confirmation-dialog dismissable by keyboard

90cc791

lukasvice requested a review from alexlanz

January 9, 2024 12:34

lukasvice self-assigned this

github-actions bot commented Jan 9, 2024

Preview link: https://306.react-ui.aboutbits.dev

alexlanz approved these changes

View reviewed changes

lukasvice merged commit 3f92cd5 into main

5 checks passed

lukasvice deleted the dismiss-confirmation-dialog branch

January 9, 2024 12:43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet