-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add transparent variant to section footer with pagination #300
Conversation
Preview link: https://300.react-ui.aboutbits.dev |
[SectionFooterVariant.Solid]: 'bg-neutral-100 border-t border-neutral-200', | ||
[SectionFooterVariant.Transparent]: '', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Omitting the border in the transparent variant means that the transparent footer is 1px smaller than the solid one. But it probably doesn't matter in this case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is right
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if this is really a section footer? When you look at the design of Aichner, then this is for me more just simply the pagination placed somewhere at the site. There is no section wrapper around the whole part.
I am talking about the dashboard page of Aichner. There is no border, but it is a section nevertheless. |
Yes, I'm also talking about this. I would like to discuss this tomorrow in person. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I talked to Martin and Tobi and you are right! Let's ship it 🚀
Adds a transparent variant that we need for Aichner.
MDX stories have also been converted to TSX stories.