Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add transparent variant to section footer with pagination #300

Merged
merged 2 commits into from
Nov 22, 2023

Conversation

devgioele
Copy link
Contributor

@devgioele devgioele commented Nov 21, 2023

Adds a transparent variant that we need for Aichner.

MDX stories have also been converted to TSX stories.

@devgioele devgioele self-assigned this Nov 21, 2023
Copy link

Preview link: https://300.react-ui.aboutbits.dev

Comment on lines +82 to +83
[SectionFooterVariant.Solid]: 'bg-neutral-100 border-t border-neutral-200',
[SectionFooterVariant.Transparent]: '',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Omitting the border in the transparent variant means that the transparent footer is 1px smaller than the solid one. But it probably doesn't matter in this case.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is right

Copy link
Member

@alexlanz alexlanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if this is really a section footer? When you look at the design of Aichner, then this is for me more just simply the pagination placed somewhere at the site. There is no section wrapper around the whole part.

@devgioele
Copy link
Contributor Author

I'm not sure if this is really a section footer? When you look at the design of Aichner, then this is for me more just simply the pagination placed somewhere at the site. There is no section wrapper around the whole part.

I am talking about the dashboard page of Aichner. There is no border, but it is a section nevertheless.

@devgioele devgioele requested a review from alexlanz November 21, 2023 14:37
@alexlanz
Copy link
Member

Yes, I'm also talking about this. I would like to discuss this tomorrow in person.

Copy link
Member

@alexlanz alexlanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I talked to Martin and Tobi and you are right! Let's ship it 🚀

@devgioele devgioele merged commit c5e682a into main Nov 22, 2023
4 checks passed
@devgioele devgioele deleted the transparent-section-footer-with-pagination branch November 22, 2023 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants