Migrate button to tsx #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview link: https://291.react-ui.aboutbits.dev |
devgioele
suggested changes
Sep 21, 2023
Comment on lines
87
to
90
| /** | ||
| * The `Mode` determines if the component is placed on LIGHT or DARK background. | ||
| */ | ||
|
|
There was a problem hiding this comment.
Apart from there being a sporadic newline, this jsdoc comment seems worthless to me
Comment on lines
120
to
123
| /** | ||
| * The size determine the padding between the button text and its border. | ||
| */ | ||
|
|
There was a problem hiding this comment.
Same here. I would remove this jsdoc
Comment on lines
36
to
41
| The **_default values_** for variant, size, and tone can be found in | ||
| the [Button Section](/docs/components-button-button--docs). The | ||
| submit button uses `React Hook Form` to automatically disable during | ||
| submitting. When the submit button is not placed inside a form (i.e. | ||
| it has no form context), you can use the `formControl` prop to pass | ||
| the control of the form. |
There was a problem hiding this comment.
The information about default values seems unnecessary. The rest is good, but I would put it as a jsdoc of the component SubmitButton
devgioele
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.