Filter fields #286
Filter fields #286
Conversation
|
Preview link: https://286.react-ui.aboutbits.dev |
There was a problem hiding this comment.
While the review I found some points that started some thoughts in my head if it is a good idea to add these components to ReactUI. These components are really opinionated and contain lots of hardcoded stylings.
I see the benefit of having them, but I think it is a better idea to store these components in a shared place inside the project.
It makes also totally sense to already create them in the boilerplate.
What is your opinion on this @lukasvice?
There was a problem hiding this comment.
Can we create a story for these?
There was a problem hiding this comment.
They are already shown in the List examples: https://286.react-ui.aboutbits.dev/?path=/story/examples-list--list-with-filter
There was a problem hiding this comment.
Can we create a story for these?
There was a problem hiding this comment.
See the comment above
| <SearchField | ||
| {...filterProps} | ||
| variant={FormVariant.Soft} | ||
| className={classNames('w-full grow md:w-auto', className)} |
There was a problem hiding this comment.
I don't know if it is a good idea to hardcode the classes here.
What's your take on this @lukasvice?
There was a problem hiding this comment.
It is what we always use according to our latest design specification
There was a problem hiding this comment.
Yes, but why not use the theme? Note that Tailwind is configured to look for class names only in theme files and not in component files!
There was a problem hiding this comment.
My bad. I didn't understand the comment. Of course I will put them in the theme file
| return ( | ||
| <SelectField | ||
| {...filterProps} | ||
| variant={isScreenMedium ? FormVariant.Transparent : FormVariant.Soft} |
There was a problem hiding this comment.
Like this we have no change to:
- Adjust screen sizes in a project
- Adjust the logic if the soft or transparent should be used for different screen size
There was a problem hiding this comment.
This is only the default. The variant can be overwritten to your liking
Form fields are opinionated too. I think filter forms are just an addition and nothing ground-breaking new. |
|
I discussed this with @alexlanz and the conclusion is that we do not add filter fields for the time being |
Introduces filter fields that follow the same pattern of form fields. Allows for less boilerplate code. Other filter fields might be added in the future.