Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix jumping SelectItemFormField size #281

Closed
wants to merge 1 commit into from
Closed

Fix jumping SelectItemFormField size #281

wants to merge 1 commit into from

Conversation

alexlanz
Copy link
Member

No description provided.

@github-actions
Copy link

Preview link: https://281.react-ui.aboutbits.dev

@alexlanz alexlanz requested a review from devgioele September 14, 2023 08:34
@alexlanz
Copy link
Member Author

https://linear.app/aboutbits/issue/AB-144/the-selectitemformfield-component-continuously-resizes-while-searching

devgioele
devgioele suggested changes Sep 14, 2023
View reviewed changes
Copy link
Contributor

@devgioele devgioele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dialog shrinks when no results are found. Should we maintain the same height when no results are found?

@alexlanz
Copy link
Member Author

I will ask Tobias what his opinion is.

@alexlanz alexlanz closed this Dec 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devgioele devgioele devgioele requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexlanz @devgioele