Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hamburger icon needs to replace with close icon after menu opens #149 #167

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Hamburger icon needs to replace with close icon after menu opens #149 #167

wants to merge 1 commit into from

Conversation

kapilG0
Copy link

@kapilG0 kapilG0 commented Jul 14, 2024

image
image

@vercel Vercel
Copy link

vercel bot commented Jul 14, 2024

@kapilG0 is attempting to deploy a commit to the Abhijeet's projects Team on Vercel.

A member of the Team first needs to authorize it.

github-actions[bot]
github-actions bot reviewed Jul 14, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to Our repository.🎊 Thank you so much for taking the time to point this out.

@kapilG0 kapilG0 mentioned this pull request Jul 14, 2024
Open
abhijeetnishal
abhijeetnishal reviewed Jul 17, 2024
View reviewed changes
client/package.json
@@ -11,6 +11,7 @@
},
"dependencies": {
"cookies-next": "^4.2.1",
"font-awesome": "^4.7.0",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't use external library, instead use custom icons, see icons folder how we are creating it and using it.

abhijeetnishal
abhijeetnishal reviewed Jul 17, 2024
View reviewed changes
client/src/app/globals.css
@@ -1,6 +1,7 @@
@tailwind base;
@tailwind components;
@tailwind utilities;
@import 'font-awesome/css/font-awesome.min.css';
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this

@abhijeetnishal
Copy link
Owner

Hey @kapilG0, i have reviewed the code and add some changes. Do the necessary changes, i will merge the code then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhijeetnishal abhijeetnishal abhijeetnishal left review comments

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kapilG0 @abhijeetnishal