Update apollo client to v3 #39
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aghreed
commented
Dec 21, 2021
| @@ -41,23 +41,23 @@ | |||
| "threshold": "1 Kb" | |||
| } | |||
| ], | |||
| "dependencies": { | |||
| "@apollo/client": "^3.5.6", | |||
| "apollo-fragment-utils": "^0.2.1", | |||
There was a problem hiding this comment.
I'll need to bump the version of apollo-fragment-utils once it gets published with the changes. Wondering if there's a better way to do that with lerna... or if this has to be a two step operation
aghreed
commented
Dec 21, 2021
Comment on lines
+7
to
+11
| if ( | ||
| fragmentAST.definitions && | ||
| fragmentAST.definitions[0] && | ||
| fragmentAST.definitions[0].kind === Kind.FRAGMENT_DEFINITION | ||
| ) { |
There was a problem hiding this comment.
Had to make some updates here for TS to compile.
Would appreciate feedback on the console.warn usage here
aghreed
commented
Dec 21, 2021
Comment on lines
12
to
13
| "apollo-link-state": "^0.4.1", | ||
| "apollo-link-state-fragment": "^0.1.0", |
There was a problem hiding this comment.
Jury is still out on what to do with these deps. Will circle back after having a conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More updates needed to these packages... still working through details locally to ensure we don't have to needlessly get into a merge+publish cycle.