-
-
Notifications
You must be signed in to change notification settings - Fork 254
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
⚡️Core: APIs Bug Fixes and Enhancements
#### WebGear_RTC: - Optimized peer connection closure to avoid redundant closures. - Reduced unnecessary logging by only logging ICE connection state changes when they are not in a "failed" state. #### StreamGear: - Enhanced stream copy support in Single Source mode (Fixes #396) - Ignored stream copy parameter in Real-time Frames Mode or Custom Streams with appropriate warnings. - Updated `-acodec` handling: - Default to `aac` for Custom Streams. - Use stream copy (`-acodec copy`) for input video’s audio when Custom Streams are disabled. - Refined `-livestream` parameter usage to Real-time Frames Mode only. - Adjusted video and audio bitrate assignment to skip when stream copy is enabled. - Improved log message for `-clear_prev_assets` parameter. - Moved handle streaming format to beginning to fix 'StreamGear' object has no attribute '_StreamGear__format' bug. #### CamGear: - Removed GStreamer support check. - Improved readability of livestream warning logs. #### WriterGear: - Improved error handling in `execute_ffmpeg_cmd` method: - Raised `ValueError` with descriptive messages for `BrokenPipeError` or `IOError`. - Updated error handling per PEP 409 to preserve original exception context or suppress it based on logging settings. #### NetGear: Updated parameters and documentation (Fixes #390) - Added warning log for potential issues with `flag=1` (NOBLOCK). - Noted that `track` option is ignored when `copy=True`. ### Core: - Improved exception handling for module imports. - Updated `import_dependency_safe` in `helper.py`: - dded specific handling for `ModuleNotFoundError`. - Included original exception in `ImportError` for better error tracing. - Enhanced logging to include exception traceback when error is set to "log". - Enhanced `import_core_dependency` in `__init__.py`: - Added specific handling for `ModuleNotFoundError`. - Included original exception in `ImportError` for better error tracing. #### Maintenance: - Refactored colorspace handling in videocapture gears - Logged a warning and discarded invalid colorspace values instead of raising an exception. - Consolidated colorspace logging into a single line using a ternary operation. - Simplified code using short-circuiting. - Corrected a typo in comments. - Removed unnecessary parentheses and type checks. - Removed unused imports. #### Docs: - Enhanced StreamGear documentation: - Added a tip box on benefits of using stream copy (`-vcodec copy`) for faster HLS/DASH transcoding. - Highlighted limitations of stream copy, including incompatibility with Real-time Frames Mode and Custom Streams. - Clarified automatic audio stream copy (`-acodec copy`) usage with input video’s audio stream. - Changed default value of `copy` to `True` in NetGear API documentation. - Fixed typos, formatting, code highlighting, and grammar issues. #### CI: - Enhanced WebGear RTC tests - Updated NetGear unit tests to reflect the new default for `copy`. - Fixed simplejpeg and opencv not compatible with `numpy==2.x.x` versions. - Pinned `numpy<2.0.0` in all CI envs. - Added test cases for import_dependency_safe function to validate different scenarios and error handling in `import_dependency_safe`. - Ensured coverage for `raise`, `log`, `silent`, and unknown error types. - Fixed invalid escape sequence in testcase string. - Fixed python environment bugs in `appveyor.yml`. - Removed pinned `cryptography==38.0.4` dependency.
- Loading branch information
Showing
27 changed files
with
312 additions
and
252 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.