Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor error handling. #80

Merged
merged 1 commit into from
May 17, 2024
Merged

Conversation

James-Burgess
Copy link
Contributor

  • Split nests into functions
  • Update fallback error to include api response.
  • Assert all branches end in default error

@James-Burgess James-Burgess force-pushed the master branch 2 times, most recently from cf1bcb7 to 6845eb0 Compare May 17, 2024 11:03
- Split nests into functions
- Update fallback error to include api response.
- Assert all branches end in default error
@codecov-commenter
Copy link

codecov-commenter commented May 17, 2024

Codecov Report

Attention: Patch coverage is 67.56757% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 92.96%. Comparing base (f12eecb) to head (6d9dbeb).
Report is 1 commits behind head on master.

Files Patch % Lines
herepy/routing_api.py 67.56% 12 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #80      +/-   ##
==========================================
- Coverage   93.25%   92.96%   -0.29%     
==========================================
  Files          26       26              
  Lines        1735     1749      +14     
==========================================
+ Hits         1618     1626       +8     
- Misses        117      123       +6     
Flag Coverage Δ
unittests 92.96% <67.56%> (-0.29%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@abdullahselek abdullahselek self-requested a review May 17, 2024 11:30
Copy link
Owner

@abdullahselek abdullahselek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 😎 thank you!

@abdullahselek abdullahselek merged commit 87bfa5c into abdullahselek:master May 17, 2024
20 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants