Skip to content

Commit

Permalink
Merge pull request #78 from James-Burgess/master
Browse files Browse the repository at this point in the history
  • Loading branch information
abdullahselek authored May 17, 2024
2 parents 8fc6b96 + f12eecb commit 0e31aea
Show file tree
Hide file tree
Showing 3 changed files with 20 additions and 0 deletions.
2 changes: 2 additions & 0 deletions herepy/routing_api.py
Original file line number Diff line number Diff line change
Expand Up @@ -987,6 +987,8 @@ def error_from_routing_service_error(json_data):
# V8 error handling
if "error" in json_data and json_data["error"] == "Unauthorized":
return InvalidCredentialsError(json_data["error_description"])
elif "error" in json_data and json_data["error"] == "Forbidden":
return InvalidCredentialsError(json_data["error_description"])
elif "status" in json_data:
error_msg = str.format(
"Cause: {0}; Action: {1}", json_data["cause"], json_data["action"]
Expand Down
4 changes: 4 additions & 0 deletions testdata/models/routing_error_forbidden_credentials.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
{
"error": "Forbidden",
"error_description": "These credentials do not authorize access"
}
14 changes: 14 additions & 0 deletions tests/test_routing_api.py
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,20 @@ def test_carroute_when_error_invalid_credentials_occurred(self):
with self.assertRaises(herepy.InvalidCredentialsError):
api.car_route([11.0, 12.0], [22.0, 23.0])

@responses.activate
def test_carroute_when_error_forbidden_credentials_occurred(self):
with open("testdata/models/routing_error_forbidden_credentials.json", "r") as f:
expectedResponse = f.read()
responses.add(
responses.GET,
"https://route.ls.hereapi.com/routing/7.2/calculateroute.json",
expectedResponse,
status=401,
)
api = herepy.RoutingApi("forbidden_api_key", "forbidden_app_code")
with self.assertRaises(herepy.InvalidCredentialsError):
api.car_route([11.0, 12.0], [22.0, 23.0])

@responses.activate
def test_carroute_when_error_no_route_found_occurred(self):
with open("testdata/models/routing_error_no_route_found.json", "r") as f:
Expand Down

0 comments on commit 0e31aea

Please sign in to comment.