Dev/ahentabl/fix dir ci (#8)

abdelrahim-hentabli · Dec 30, 2023 · 5327329 · 5327329
1 parent bdac8ba
commit 5327329
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
@@ -15,4 +15,4 @@ jobs:
       - name: Run Cmake Config step
         run:  cmake ../ray-tracing
       - name: Run build
-        run:  cmake --build . --parallel 2
+        run:  cmake --build . --parallel 2
diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt
@@ -1,5 +1,8 @@
 add_executable(ray_tracer main.cpp camera.cpp hierarchy.cpp dump_png.cpp flat_shader.cpp parse.cpp phong_shader.cpp plane.cpp reflective_shader.cpp render_world.cpp sphere.cpp box.cpp mesh.cpp)
 find_package(PNG REQUIRED)
-include_directories(${PNG_INCLUDE_DIR} ../include)
 
-target_link_libraries(ray_tracer ${PNG_LIBRARY})
+target_include_directories(ray_tracer
+    PRIVATE ${PNG_INCLUDE_DIR}
+    PRIVATE ${PROJECT_SOURCE_DIR}/include)
+
+target_link_libraries(ray_tracer ${PNG_LIBRARY})