Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New query bar #30

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from
Draft

New query bar #30

wants to merge 11 commits into from

Conversation

abbyhu2000
Copy link
Owner

Description

Issues Resolved

Screenshot

Testing the changes

Changelog

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

kavilla
kavilla reviewed Jul 11, 2024
View reviewed changes
src/plugins/data/public/ui/query_editor/query_editor.tsx
@@ -289,12 +293,29 @@ export default class QueryEditorUI extends Component<Props, State> {
const headerClassName = classNames('osdQueryEditorHeader', this.props.headerClassName);
const bannerClassName = classNames('osdQueryEditorBanner', this.props.bannerClassName);

const useQueryEditor =
this.props.query.language === 'SQLAsync' ||
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can add this boolean here: https://github.com/opensearch-project/OpenSearch-Dashboards/blob/96fb9d629e6539db4dacd922df3fff6809fdb407/src/plugins/data/public/ui/types.ts#L23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kavilla kavilla kavilla left review comments

Assignees
No one assigned
Labels
valued-contributor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abbyhu2000 @kavilla