Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log tail #25

Merged
merged 8 commits into from
Apr 19, 2020
Merged

Log tail #25

merged 8 commits into from
Apr 19, 2020

Conversation

sbcgua
Copy link
Collaborator

@sbcgua sbcgua commented Apr 18, 2020

to #22

decided to add it back for now. Logging may take some extra time to make it properly (and to agree with you the concept ;)))

So:

  • in-mem log is now in a separate module + UT
  • with some extra utils
  • it checks ALB_SUPPRESS_FRONPAGE_LOG env to remove it from frontpage
  • logs wrong requests too (for security overview)
  • docs updated
  • some minor cleanups with tests, sorry couldn't stand from

@sbcgua sbcgua requested a review from larshp April 18, 2020 09:06
@sbcgua
Copy link
Collaborator Author

sbcgua commented Apr 18, 2020 •
edited
Loading

offtopic: bzw why you prefer " to ' ? ' is easier to type

@sbcgua sbcgua mentioned this pull request Apr 18, 2020
Merged
@larshp
Copy link
Member

larshp commented Apr 19, 2020

prefer consistency not super much the one over the other, double quotes is part of normal written language, feel free to change for this repo

cf push tested ok, merging

@larshp larshp merged commit 649ed16 into abaplint:master Apr 19, 2020
@sbcgua sbcgua deleted the log-tail branch April 19, 2020 08:50
@sbcgua
Copy link
Collaborator Author

sbcgua commented Apr 19, 2020

👍

quotes. ok ... well, if you don't mind maybe I'll change it later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@larshp larshp Awaiting requested review from larshp

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sbcgua @larshp