Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add addInfo back into code #22

Closed
larshp opened this issue Mar 26, 2020 · 11 comments
Closed

add addInfo back into code #22

larshp opened this issue Mar 26, 2020 · 11 comments
Assignees

Comments

@larshp
Copy link
Member

larshp commented Mar 26, 2020

removed in https://github.com/abaplint/abaplint-cloud-foundry/pull/18/files

@sbcgua

#18

@sbcgua
Copy link
Collaborator

sbcgua commented Mar 26, 2020

I have another suggestion for this. Either external log system if this is for internal usage (I'll propose more specifically later) or the same result in the fronpage but with another approach (custom logger library transport)

@larshp
Copy link
Member Author

larshp commented Mar 26, 2020

just need easy access to

  • request type
  • Object Type(if its check_object)
  • inbound payload size
  • response time

last 10 requests would be okay

@sbcgua
Copy link
Collaborator

sbcgua commented Mar 26, 2020

OK, got it

@larshp
Copy link
Member Author

larshp commented Mar 26, 2020

and if the processing for some reason gives an exception, also add to list

@sbcgua
Copy link
Collaborator

sbcgua commented Mar 26, 2020

OK. But it's a separate PR please. I'd like to go on with docker first and then improve the logging

@larshp
Copy link
Member Author

larshp commented Mar 26, 2020

yea, thats why I opened it as an issue :)

@sbcgua
Copy link
Collaborator

sbcgua commented Apr 11, 2020

linked to #19

@sbcgua
Copy link
Collaborator

sbcgua commented Apr 11, 2020

hmmm, how to self assign ? Seems like no such option in this repo, strange ?

@larshp
Copy link
Member Author

larshp commented Apr 11, 2020

@sbcgua I've invited you, try again

@sbcgua sbcgua self-assigned this Apr 11, 2020
@sbcgua
Copy link
Collaborator

sbcgua commented Apr 11, 2020

yeap, works now 👍

@sbcgua sbcgua mentioned this issue Apr 18, 2020
@sbcgua
Copy link
Collaborator

sbcgua commented Apr 19, 2020

can be closed ?

@larshp larshp closed this as completed Apr 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants