Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fix risk steward import issue #21

Merged
merged 2 commits into from
Dec 3, 2024
Merged

🐛 fix risk steward import issue #21

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
785087a
🐛 fix issue
MartinGbz Dec 3, 2024
4d88736
🐛 avoid using a temp var
MartinGbz Dec 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions generator/templates/proposal.template.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,14 @@ import {prefixWithPragma} from '../utils/constants';
export const proposalTemplate = (
options: Options,
poolConfig: PoolConfig,
pool: PoolIdentifier,
pool: PoolIdentifier
) => {
const {title, author, discussion} = options;
const chain = getPoolChain(pool);

// Edge case: use BaseChain instead of Base for RiskStewards network
const riskStewardChain = chain === 'Base' ? 'BaseChain' : chain;

const folderName = generateFolderName(options);
const contractName = generateContractName(options, pool);

Expand All @@ -23,10 +27,11 @@ export const proposalTemplate = (
* @title ${title || 'TODO'}
* @author ${author || 'TODO'}
* - discussion: ${discussion || 'TODO'}
* - deploy-command: make run-script contract=src/contracts/updates/${folderName}/${contractName}.sol:${contractName} network=${getChainAlias(chain)} broadcast=false generate_diff=true
* - deploy-command: make run-script contract=src/contracts/updates/${folderName}/${contractName}.sol:${contractName} network=${getChainAlias(
chain
)} broadcast=false generate_diff=true
*/
contract ${contractName} is ${`RiskStewards${chain}`
} {
contract ${contractName} is ${`RiskStewards${riskStewardChain}`} {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
contract ${contractName} is ${`RiskStewards${riskStewardChain}`} {
contract ${contractName} is ${`RiskStewards${chain === 'Base' ? 'BaseChain' : chain}`} {

I would put the condition here directly instead of declaring a new constant

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushed a fix (cause with this suggestion I needed to also remove the riskStewardChain const

function name() public pure override returns (string memory) {
return '${contractName}';
}
Expand Down
Loading