Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional context to send_email_with_callback_token template and plaintext #46

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

firstTimeCaller
Copy link

Hi Aaronn,

Thank you for the great project.

I am interested in having the emailed token within a URL. This will mean a user will only have to click on the anchor, rather then copying and pasting the token. As the users email is also required for auth_token I have added this in the link.

@jws
Copy link
Contributor

jws commented Feb 12, 2020

a solution here should be generalizable to other use cases. your email link format for example, is unlikely to be usable by others.

another approach is to extend the context processing scaffold in inject_template_context and actually invoke the processors with sufficient context (i.e. email) to be actionable. right now, nothing is provided to the processors, which limits their usefulness. once that is in place, you can leverage the context processor extension + override the email template to format any url that you need.

@firstTimeCaller
Copy link
Author

JWS, your suggestion is so much more elegant! I can't believe I didn't see the simpler solution of passing the user to the template. I will update accordingly.

@firstTimeCaller firstTimeCaller changed the title email token as URL Add additional context to send_email_with_callback_token template and plaintext Feb 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants