Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy to Dawn Staging Theme [Aligent's Shopify Test Store] #1

Closed
wants to merge 3 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Sep 6, 2024

This pipeline is currently connected to Aligent's Shopify Test Store.
Once the team has reviewed the process and flow and everything looks good, I will update the connection to switch over to Naturally Sweet.

Aaron Medina added 3 commits September 6, 2024 13:12
…al development. Currently connected to Aligent's test store. Need to update the credentials to Naturally Sweet's once reviewed and ready for use.
@ghost ghost requested review from hubertott, TheOrangePuff, AdamJHall, gowrizrh, crispy101 and a user September 6, 2024 05:14
@ghost ghost self-assigned this Sep 6, 2024
@ghost
Copy link
Author

ghost commented Sep 6, 2024

This repo and pipeline is only for pushing Shopify theme changes.
The scripts folder contains help scripts for local development.

name: Naturally Sweet Shopify Theme Deployment

on:
push:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My GHA might be dated, but I found this too sensitive in the past.

I have previously used the pull_request trigger instead and in the Job added a merge check to only run the job when the merge completed.

on:
  pull_request:
    types:
      - closed
    branches:
      - staging

jobs:
  theme-check:
    name: Theme Check
    # PR must must be merged, not closed to trigger a deployment
    if: github.event.pull_request.merged
   ...

password: ${{ secrets.DOCKERHUB_SECRET_KEY }}
steps:
- name: Checkout code
uses: actions/checkout@v2

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most GHA default actions are @v4 now ... otherwise you'll get pipeline warnings about deprecated Node

@ghost
Copy link
Author

ghost commented Sep 8, 2024

Thanks @hubertott, will check the concerns and will apply the updates accordingly.

@ghost ghost closed this Sep 9, 2024
@ghost ghost deleted the feature/set-up branch September 10, 2024 03:48
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant