Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: replace pp with ppft #39

Merged
merged 1 commit into from
Oct 24, 2024
Merged

feat: replace pp with ppft #39

merged 1 commit into from
Oct 24, 2024

Conversation

sanjayankur31
Copy link
Collaborator

Fixes #34

@sanjayankur31
Copy link
Collaborator Author

@aarongarrett would you please take a quick look at this just to confirm that it all looks OK when you have a minute? ppft is a drop in replacement for pp, so it should be fine.

@sanjayankur31 sanjayankur31 linked an issue Oct 23, 2024 that may be closed by this pull request
Test using ppft in place of pp #34
Closed
@aarongarrett
Copy link
Owner

Yes, that looks like a painless drop-in.

@sanjayankur31 sanjayankur31 merged commit ecb244b into development Oct 24, 2024
6 of 7 checks passed
@sanjayankur31 sanjayankur31 deleted the feat-ppft branch October 24, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aarongarrett aarongarrett Awaiting requested review from aarongarrett

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test using ppft in place of pp
2 participants
@sanjayankur31 @aarongarrett