Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ChannelTabs] Added support for multiple languages #77

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

SiongSng
Copy link

No description provided.

@SiongSng SiongSng changed the title Added support for multiple languages [ChannelTabs] Added support for multiple languages Mar 20, 2021
@aarondoet
Copy link
Owner

Thanks for this, I appreciate it. But there are three issues I see. First one being that you just use an array and indices to access them, I'd prefer if it was an object that maps a key to the message so that you actually know what you are accessing (like strings[languageId].noFav instead of string[langaugeId][0]). Second issue is the naming, Language_ID and Language, they should rather be something like strings and locale/language. You could also just use the strings property inside the config which does exactly that, then you just access the strings using this.strings.noFav. Only problem with that would be that it does not accept sub languages, so there could just be zh and not zh-TW and zh-CN. You could however also make a PR or create an issue in the repo for the library to implement that. The third problem is nothing you have control of but there currently is another PR (#76) that I would consider more important than this one, I will probably merge that soon. You would probably need to update this afterwards (with my previous points in mind) and then I'd merge it.

(Also I'd prefer if you'd keep my formatting, I don't like whitespace changes in my stuff. Maybe you can disable your linter or formatting for this small change.)

@SiongSng
Copy link
Author

Thank you! I see. I will wait for the PR(#76) merger before submitting the new multilingual translation system version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants