Skip to content

Commit

Permalink
[Vulkan] Remove deprecated EXTDebugReport
Browse files Browse the repository at this point in the history
  • Loading branch information
hyazinthh committed Apr 25, 2024
1 parent 5217787 commit ce3a26b
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 20 deletions.
11 changes: 0 additions & 11 deletions src/Aardvark.Rendering.Vulkan/Core/DebugReport.fs
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ open System.Threading
open System.Collections.Concurrent
open Aardvark.Base
open Microsoft.FSharp.NativeInterop
open EXTDebugReport
open EXTDebugUtils

type MessageSeverity =
Expand Down Expand Up @@ -80,16 +79,6 @@ module private DebugReportHelpers =
]


[<AutoOpen>]
module EnumExtensions =
type VkDebugReportFlagsEXT with
static member All =
VkDebugReportFlagsEXT.DebugBit |||
VkDebugReportFlagsEXT.ErrorBit |||
VkDebugReportFlagsEXT.InformationBit |||
VkDebugReportFlagsEXT.PerformanceWarningBit |||
VkDebugReportFlagsEXT.WarningBit

type VkDebugUtilsMessengerCallbackEXTDelegate =
delegate of VkDebugUtilsMessageSeverityFlagsEXT * VkDebugUtilsMessageTypeFlagsEXT * nativeptr<VkDebugUtilsMessengerCallbackDataEXT> * nativeint -> int

Expand Down
13 changes: 4 additions & 9 deletions src/Aardvark.Rendering.Vulkan/Core/Platform.fs
Original file line number Diff line number Diff line change
Expand Up @@ -40,10 +40,7 @@ module Instance =

let ConservativeRasterization = EXTConservativeRasterization.Name

let Debug = [
EXTDebugReport.Name
EXTDebugUtils.Name
]
let Debug = EXTDebugUtils.Name

let Raytracing = [
KHRRayTracingPipeline.Name
Expand Down Expand Up @@ -156,9 +153,9 @@ type Instance(apiVersion : Version, layers : list<string>, extensions : list<str

let extensions =
if debug.DebugReportEnabled || debug.ValidationLayerEnabled then
extensions @ Instance.Extensions.Debug
extensions @ [Instance.Extensions.Debug]
else
extensions |> List.filter (fun e -> Instance.Extensions.Debug |> List.contains e |> not)
extensions |> List.filter ((<>) Instance.Extensions.Debug)
|> List.distinct

let layers =
Expand All @@ -170,9 +167,7 @@ type Instance(apiVersion : Version, layers : list<string>, extensions : list<str
let layers, instanceExtensions = filterLayersAndExtensions layers extensions

let debugReportEnabled =
Instance.Extensions.Debug |> List.forall (fun e ->
instanceExtensions |> List.contains e
)
instanceExtensions |> List.contains Instance.Extensions.Debug

let validationEnabled =
layers |> List.contains Instance.Layers.Validation
Expand Down

0 comments on commit ce3a26b

Please sign in to comment.