Make MacOSX Bundle with working translations #748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
tobiolo
commented
Nov 3, 2024
tobiolo
commented
- To create bundle, both build and install must be run by CMake
- Localizations now need to be extra declared in Info.plist
tobiolo
force-pushed
the
macosx-bundle
branch
6 times, most recently
from
6177046 to
c3464b9
Compare
- To create bundle, both build and install must be run by CMake - Localizations now need to be extra declared in Info.plist
tobiolo
force-pushed
the
macosx-bundle
branch
from
6b74f7e to
6f48844
Compare
|
After adjusting the CI we might also throw away the XCode files. |
|
LGTM |
|
Thanks for looking into! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.