Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wxSizeEvent should not trigger a repaint of the document #593

Merged
merged 1 commit into from
Jan 15, 2024

Conversation

tobiolo
Copy link
Collaborator

@tobiolo tobiolo commented Jan 14, 2024

The document is rendered into a scrolled window. If the size of the scrolled window for the canvas is changed, the rendered document can stay the same as it can be navigated by the scrollbars.

This should avoid the expensive Document::Refresh() call.

…document

The document is rendered into a scrolled window. If the size of the scrolled
window for the canvas is changed, the rendered document can stay the same
as it can be navigated by the scrollbars.

This should avoid the expensive `Document::Refresh()` call.
@tobiolo tobiolo changed the title TSCanvas::OnSize(wxSizeEvent&) should not trigger a repaint of the … wxSizeEvent should not trigger a repaint of the document Jan 14, 2024
@tobiolo tobiolo requested a review from aardappel January 14, 2024 14:15
@aardappel
Copy link
Owner

But if it gets bigger, what causes the new area to be rendered? I presume that still happens?

@aardappel aardappel merged commit 612c8f4 into aardappel:master Jan 15, 2024
4 checks passed
@tobiolo tobiolo deleted the no-repaint-on-wxsize-event branch January 15, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants