refactor: migrate to yaml.v3 #57
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghodss/yaml is used only in config loading, and the yaml.v3 unmarshaling appears to be a drop-in replacement; the ghodss/yaml feature of reusing `json` struct tags for YAML is not used there. For other uses in the tree, yaml.v3 looks like a drop in replacement for yaml.v2, too.
scop
force-pushed
the
refactor/yaml-v3
branch
from
9c1427b to
3b10df6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ghodss/yaml is used only in config loading, and the yaml.v3 unmarshaling appears to be a drop-in replacement; the ghodss/yaml feature of reusing
jsonstruct tags for YAML is not used there.For other uses in the tree, yaml.v3 looks like a drop in replacement for yaml.v2, too.
Caveat: untested beyond test suite and
go run ./cmd/ssh-inscribe defaultsoutput eyeballing.