Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(fix) Change default == value to is #139

Merged
merged 1 commit into from
Mar 28, 2024
Merged

(fix) Change default == value to is #139

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/nnbench/runner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ def _issubtype(t1: type, t2: type) -> bool:
for bm in self.benchmarks:
for var in bm.interface.variables:
name, typ, default = var
if default == empty:
if default is empty:
required.add(name)
if name in params and default != empty:
logger.debug(
Expand All @@ -122,7 +122,7 @@ def _issubtype(t1: type, t2: type) -> bool:
orig_type, orig_val = new_type, new_val = currvar
# If a benchmark has a variable without a default value,
# that variable is taken into the combined interface as no-default.
if default == empty:
if default is empty:
new_val = default
# These types need not be exact matches, just compatible.
# Two types are compatible iff either is a subtype of the other.
Expand Down