Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Reduce non-optional dependencies #137

Merged
merged 3 commits into from
Apr 23, 2024
Merged

Feature: Reduce non-optional dependencies #137

merged 3 commits into from
Apr 23, 2024

Conversation

samuelburbulla
Copy link
Collaborator

Feature: Reduce non optional dependencies

Description

Which issue does this PR tackle?

  • We have too many dependencies, many of them are actually optional or only needed for dev/testing.

How does it solve the problem?

  • Move several dependencies into dev.

How are the changes tested?

  • Locally: I am able to run benchmarks/run_single.py after pip install -e . only.
  • All tests run as before with pip install -e .[dev]

@samuelburbulla samuelburbulla force-pushed the feature/reduce-non-optional-dependencies branch from 611aff9 to e7075c2 Compare April 23, 2024 08:02
@samuelburbulla samuelburbulla changed the title Feature: Reduce non optional dependencies Feature: Reduce non-optional dependencies Apr 23, 2024
@samuelburbulla samuelburbulla merged commit e69c39a into main Apr 23, 2024
14 checks passed
@samuelburbulla samuelburbulla deleted the feature/reduce-non-optional-dependencies branch April 23, 2024 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@samuelburbulla