New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix picture conversion function in README #149

Open

csandman wants to merge 1 commit into aadsm:master from csandman:csandman/readme-edits

csandman commented Jul 28, 2021

There were two issues I noticed when I copied over the example conversion function from ArrayBuffer to Base64 data url.

First, the i index variable is declared as a const when it should be a let.

Second, the data variable is being destructured from the picture tag but never used.

Both of these typos are fixed in this PR


          Fix picture conversion function in README

5245f27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet