Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for list view and links to tinfoil.media for more details #152

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

benmcmath
Copy link

Added support for the list view and added links to tinfoil.media to get details of game.

@benmcmath
Copy link
Author

Screenshot 2024-11-13 at 4 22 32 PM

@a1ex4
Copy link
Owner

a1ex4 commented Dec 9, 2024

This looks great thank you! Could you change the target branch to develop?

@benmcmath benmcmath changed the base branch from master to develop December 9, 2024 23:33
@benmcmath
Copy link
Author

I have changed the targeted branch to develop.

@benmcmath
Copy link
Author

@a1ex4 Any chance to get this merged to develop?

@a1ex4
Copy link
Owner

a1ex4 commented Dec 19, 2024

I tested your changes and there are two things that don't suit what I am aming for with the project:

  • the list view is supposed to be similar to a 'details' view, in a table display with column like release date, added date, genres, size, list of files...
  • the shop should not rely on anything external and contain all the infos related to your library

Here the list view doesn't add anything and is just like the other views, and the link to Tinfoil website defeats the purpose of the shop, all the same info from the Tinfoil website is already available in the games' data in the Ownfoil page 😉

@benmcmath
Copy link
Author

Perfectly understandable. I was simply aiming to get the unused list button to show the titles, well, as a list. The link to the external site was mainly for the screenshots as I personally like to get a visual representation of what the games will look like. I wasn't aware they were in the info already. Feel free to close the PR as it doesn't seem to align with your vision.

I'm not great with Python, but enough to help. Feel free to reach out if you are looking for any other simple help. I thoroughly enjoy using Ownfoil for my personal collection.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants