Skip to content

Commit

Permalink
ci(install): fix browser install
Browse files Browse the repository at this point in the history
  • Loading branch information
j-mendez committed Sep 18, 2023
1 parent 2b10a18 commit 45f63f7
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 6 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/bench.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ jobs:
run: cd kayle_innate && wasm-pack build --target nodejs && cd ../

- name: Install and build locales
run: npx playwright install --with-deps chromium && yarn --no-immutable && yarn build
run: yarn --no-immutable && yarn build && npx playwright install --with-deps chromium

- name: Run Bench playwright fast_axecore
run: cd ./kayle && yarn bench:playwright:axe
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/perf.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ jobs:
run: cd kayle_innate && wasm-pack build --target nodejs && cd ../

- name: Install and build locales
run: npx playwright install --with-deps chromium && yarn --no-immutable && yarn build
run: yarn --no-immutable && yarn build && npx playwright install --with-deps chromium

- name: Run Bench fast_htmlcs
run: cd ./kayle && yarn bench:playwright:htmlcs > output.json
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ jobs:
run: cd kayle_innate && wasm-pack build --target nodejs && cd ../

- name: Install and build locales
run: npx playwright install --with-deps chromium && yarn --no-immutable && yarn build
run: yarn --no-immutable && yarn build && npx playwright install --with-deps chromium

- name: Run Playwright kayle.js
run: cd ./kayle && yarn test:playwright && yarn test:playwright:axe
Expand Down
4 changes: 1 addition & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ const results = await kayle({
});
```

![Video of clips being stored of the issue to get visual feedback](https://user-images.githubusercontent.com/8095978/268726837-f362a490-b611-4acf-8cb6-104f58a0a6c7.gif)
![Images of issues being stored of the to get visual feedback.](https://user-images.githubusercontent.com/8095978/268726837-f362a490-b611-4acf-8cb6-104f58a0a6c7.gif)

## Runners

Expand Down Expand Up @@ -161,8 +161,6 @@ type RunnerConfig = {
1. zh-CN ("Chinese-Simplified")
1. zh-TW ("Chinese-Traditional")

![Video of clips being stored of the issue to get visual feedback](https://user-images.githubusercontent.com/8095978/268726837-f362a490-b611-4acf-8cb6-104f58a0a6c7.gif)

## Testing

For the comparison between using `fast_htmlcs`, `fast_axecore`, and the metrics for the 3rd party `@axe-core/playwright`.
Expand Down

0 comments on commit 45f63f7

Please sign in to comment.