chore(rules): add img ignore alt empty title [H67]

a11ywatch · Oct 22, 2023 · 4d3b7dc · 4d3b7dc
1 parent 37ea0d6
commit 4d3b7dc
Show file tree

Hide file tree

Showing 10 changed files with 68 additions and 9 deletions.
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/RULES.md b/RULES.md
@@ -20,16 +20,17 @@ List of [WCAG2.1 techniques](https://www.w3.org/TR/WCAG21/) and whether or not w
 | [H57](https://www.w3.org/TR/WCAG20-TECHS/H57.html) | lang attribute of the document element does not appear to be well-formed      | A-AAA | error | 3.Lang          | ✅       |
 | [H57](https://www.w3.org/TR/WCAG20-TECHS/H57.html) | xml:lang attribute of the document element does not appear to be well-formed  | A-AAA | error | 3.XmlLang       | ✅       |
 | [H64](https://www.w3.org/TR/WCAG20-TECHS/H64.html) | iframe missing title attribute                                                | A-AAA | error | 1               | ✅       |
+| [H67](https://www.w3.org/TR/WCAG20-TECHS/H67.html) | Img element with empty alt text must have absent or empty title attribute     | A-AAA | error | 1               | ✅       |
 | [H71](https://www.w3.org/TR/WCAG20-TECHS/H71.html) | fieldset missing legend element                                               | A-AAA | error | 2               | ✅       |
 | [H91](https://www.w3.org/TR/WCAG20-TECHS/H91.html) | anchor valid href attribute, but no link content                              | A-AAA | error | A.NoContent     | ✅       |
 | [H91](https://www.w3.org/TR/WCAG20-TECHS/H91.html) | anchor found but no link content                                              | A-AAA | error | A.EmptyNoId     | ✅       |
 | [H91](https://www.w3.org/TR/WCAG20-TECHS/H91.html) | form control needs name                                                       | A-AAA | error | [NodeName].Name | ✔️        |
-| [H93](https://www.w3.org/TR/WCAG20-TECHS/H93.html) | label has multiple for ids                                                    | A-AAA | error |                 | ✅        |
+| [H93](https://www.w3.org/TR/WCAG20-TECHS/H93.html) | label has multiple for ids                                                    | A-AAA | error |                 | ✅       |
 | [F40](https://www.w3.org/TR/WCAG20-TECHS/F40.html) | meta redirect used with a time limit                                          | A-AAA | error | 2               | ✅       |
 | [F41](https://www.w3.org/TR/WCAG20-TECHS/F41.html) | meta refresh used to reload the page                                          | A-AAA | error | 2               | ✅       |
 | [F47](https://www.w3.org/TR/WCAG20-TECHS/F47.html) | blink element used for attention                                              | A-AAA | error |                 | ✅       |
 | [F77](https://www.w3.org/TR/WCAG20-TECHS/F77.html) | duplicate ID found                                                            | A-AAA | error |                 | ✅       |
 
-Errors that can be to be tested with automation `23/70`.
+Errors that can be to be tested with automation `24/70`.
 
 Key: ✅ = Complete, ✔️ = Complete with a bit of missing details.
diff --git a/accessibility-rs/Cargo.toml b/accessibility-rs/Cargo.toml
@@ -1,6 +1,6 @@
 [package]
 name = "accessibility-rs"
-version = "0.0.40"
+version = "0.0.41"
 authors = ["The A11yWatch Project Developers", "Jeff Mendez <[email protected]>"]
 edition = "2021"
 license = "MIT OR Apache-2.0"

diff --git a/accessibility-rs/src/engine/issue.rs b/accessibility-rs/src/engine/issue.rs
@@ -61,7 +61,7 @@ impl Issue {
         Issue {
             message,
             context: context.into(),
-            runner: "kayle",
+            runner: "accessibility-rs",
             code: code.into(),
             issue_type,
             type_code: match issue_type {

diff --git a/accessibility-rs/src/engine/rules/techniques.rs b/accessibility-rs/src/engine/rules/techniques.rs
@@ -27,6 +27,8 @@ pub enum Techniques {
     H63,
     /// <https://www.w3.org/TR/WCAG20-TECHS/H64>
     H64,
+    /// <https://www.w3.org/TR/WCAG20-TECHS/H67>
+    H67,
     /// <https://www.w3.org/TR/WCAG20-TECHS/H71>
     H71,
     /// <https://www.w3.org/TR/WCAG20-TECHS/H91>

diff --git a/accessibility-rs/src/engine/rules/utils/nodes.rs b/accessibility-rs/src/engine/rules/utils/nodes.rs
@@ -19,14 +19,30 @@ pub fn has_alt(ele: ElementRef<'_>) -> bool {
     has_alt_prop(ele)
 }
 
-/// a valid alt attribute for image
+/// a valid attribute for element
 pub fn has_alt_prop(ele: ElementRef<'_>) -> bool {
     match ele.attr("alt") {
         Some(_) => true,
         _ => false,
     }
 }
 
+/// property found for element
+pub fn has_prop(ele: ElementRef<'_>, prop: &str) -> bool {
+    match ele.attr(prop) {
+        Some(_) => true,
+        _ => false,
+    }
+}
+
+/// property found for element and is not empty
+pub fn has_prop_value(ele: ElementRef<'_>, prop: &str) -> bool {
+    match ele.attr(prop) {
+        Some(p) => !p.is_empty(),
+        _ => false,
+    }
+}
+
 /// elements empty
 pub fn is_empty(nodes: &ElementNodes) -> (bool, Vec<String>) {
     let mut valid = true;

diff --git a/accessibility-rs/src/engine/rules/wcag_rule_map.rs b/accessibility-rs/src/engine/rules/wcag_rule_map.rs
@@ -1,7 +1,8 @@
 use crate::engine::rules::rule::{Rule, Validation};
 use crate::engine::rules::techniques::Techniques;
 use crate::engine::rules::utils::nodes::{
-    get_unique_selector, has_alt, has_alt_prop, validate_empty_nodes, validate_missing_attr,
+    get_unique_selector, has_alt, has_alt_prop, has_prop, has_prop_value, validate_empty_nodes,
+    validate_missing_attr,
 };
 use crate::engine::rules::wcag_base::{Guideline, IssueType, Principle};
 use crate::i18n::locales::get_message_i18n_str_raw;
@@ -256,6 +257,20 @@ lazy_static! {
 
                     Validation::new(valid, "", elements, Default::default()).into()
                 }),
+                Rule::new(Techniques::H67.into(), IssueType::Error, Principle::Perceivable, Guideline::TextAlternatives, "1", |nodes, _lang| {
+                    let mut valid = true;
+                    let mut elements = Vec::new();
+
+                    for ele in nodes {
+                        let ele = ele.0;
+                        if has_prop(ele, "alt") && has_prop_value(ele, "title") {
+                            valid = false;
+                            elements.push(get_unique_selector(&ele))
+                        }
+                    }
+
+                    Validation::new(valid, "1", elements, Default::default()).into()
+                }),
             ])),
             ("h1", Vec::from([
                 Rule::new(Techniques::H42.into(), IssueType::Error, Principle::Perceivable, Guideline::Adaptable, "1", |nodes, _lang| {

diff --git a/accessibility-rs/tests/unit/img.rs b/accessibility-rs/tests/unit/img.rs
@@ -53,3 +53,28 @@ fn _audit_form_submit_img_missing_alt() {
 
     assert_eq!(valid, false)
 }
+
+#[test]
+/// img has empty alt and title
+fn _audit_form_submit_img_has_alt_and_title() {
+    let audit = accessibility_rs::audit(AuditConfig::basic(
+        r###"<html xmlns="http://www.w3.org/1999/xhtml" lang="en">
+    <head>     
+       <title>Contains Title with Alt: Do not Use.</title>
+    </head>   
+    <body>     
+        <img src="newsletter.gif" alt="" title="empty newsletter"/>
+    </body> 
+ </html>"###,
+    ));
+    let mut valid = true;
+
+    for x in &audit {
+        if x.code == "WCAGAAA.Principle1.Guideline1_1.H67" {
+            valid = false;
+            break;
+        }
+    }
+
+    assert_eq!(valid, false)
+}
diff --git a/accessibility-rs/tests/unit/label.rs b/accessibility-rs/tests/unit/label.rs
@@ -29,7 +29,7 @@ fn _audit_label_id_noexist() {
     };
 
     let audit = accessibility_rs::audit(AuditConfig::basic(&markup.into_string()));
-    
+
     let valid = !audit
         .iter()
         .any(|x| x.code == "WCAGAAA.Principle1.Guideline1_3.H44");

diff --git a/accessibility-rs/tests/unit/mod.rs b/accessibility-rs/tests/unit/mod.rs
@@ -5,5 +5,5 @@ pub mod heading;
 pub mod html;
 pub mod img;
 pub mod input;
+pub mod label;
 pub mod meta;
-pub mod label;
-Original file line number
+Diff line change
@@ Expand Up / @@ -29,7 +29,7 @@ fn _audit_label_id_noexist() { @@
         };
         let audit = accessibility_rs::audit(AuditConfig::basic(&markup.into_string()));
         let valid = !audit
             .iter()
             .any(|x| x.code == "WCAGAAA.Principle1.Guideline1_3.H44");
@@ Expand Down @@