Start reviving the cycleway snapping / sidepath zipping experiment #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dabreegster
commented
Mar 10, 2023
| @@ -80,10 +80,6 @@ fn should_collapse(road1: &Road, road2: &Road) -> Result<()> { | |||
| _ => bail!("one of the placements isn't consistent"), | |||
| } | |||
|
|
|||
| if road1.is_cycleway() && road2.is_cycleway() { | |||
There was a problem hiding this comment.
This had no effect. Even if it was false, we would choose to collapse.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First, rename "snap cycletrack" to "zip sidepath". Ben, I think you've used "zip" before as the phrasing for this kind of operation. "Sidepath" matches https://wiki.openstreetmap.org/wiki/Proposed_features/Key:is_sidepath and stops being specific to cycleways. We will also want to try this for sidewalks:
And second, pull the detection + repair logic into an operation, so that we can interactively call it from the UI:
screencast.mp4
These are smaller+simpler changes, paving the way for more complicated changes to the logic in #210.