Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ci #2

Open
wants to merge 75 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
75 commits
Select commit Hold shift + click to select a range
1c486b2
Add one codecov
jonhoo Sep 17, 2022
1b8c305
Merge another codecov
jonhoo Sep 17, 2022
7f34f79
Merge another codecov
jonhoo Sep 17, 2022
510b696
Merge another codecov
jonhoo Sep 17, 2022
b32648c
Merge another codecov
jonhoo Sep 17, 2022
126c9a3
Place codecov config under .github
jonhoo Sep 17, 2022
11027d3
Add (only) ASAN workflow
jonhoo Sep 17, 2022
bbdbd96
Add first coverage workflow
jonhoo Sep 17, 2022
fe6ba38
Merge another coverage.yml
jonhoo Sep 17, 2022
1fe2a6d
Merge another coverage.yml
jonhoo Sep 17, 2022
225ad39
Add first features workflow
jonhoo Sep 17, 2022
922692a
Merge another features workflow
jonhoo Sep 17, 2022
043eb24
Merge another features workflow
jonhoo Sep 17, 2022
d8c8a99
Merge another features workflow
jonhoo Sep 17, 2022
f67cad0
Add (only) loom workflow
jonhoo Sep 17, 2022
bf66d94
Add (only) LSAN workflow
jonhoo Sep 17, 2022
c65a7c4
Add first minial workflow
jonhoo Sep 17, 2022
77079d7
Add (only) miri workflow
jonhoo Sep 17, 2022
9b48ae3
Add first msrv workflow
jonhoo Sep 17, 2022
b60aa55
Merge another msrv workflow
jonhoo Sep 17, 2022
1113c89
Merge another msrv workflow
jonhoo Sep 17, 2022
e6ef8e3
Merge another msrv workflow
jonhoo Sep 17, 2022
c74ee96
Add (only) no-std workflow
jonhoo Sep 17, 2022
92379c8
Add first os-check workflow
jonhoo Sep 17, 2022
05dd468
Merge another os-check workflow
jonhoo Sep 17, 2022
bc3f551
Add first style workflow
jonhoo Sep 17, 2022
fe46040
Merge another style workflow
jonhoo Sep 17, 2022
3bd8b12
Merge another style workflow
jonhoo Sep 17, 2022
8953a88
Add first test workflow
jonhoo Sep 17, 2022
0910d97
Merge another test workflow
jonhoo Sep 17, 2022
971c3fd
Merge another test workflow
jonhoo Sep 17, 2022
2de2235
Merge another test workflow
jonhoo Sep 17, 2022
0f90a0b
Make everything use checkout@v3
jonhoo Sep 17, 2022
99ddee8
Standardize on 'main' as branch name
jonhoo Sep 17, 2022
8736566
Missed a submodule checkout
jonhoo Sep 17, 2022
4859c12
Add TODOs from twitter thread
jonhoo Sep 18, 2022
afa2531
Practice what you preach
jonhoo Sep 18, 2022
71c2048
mv github .github
jonhoo Sep 18, 2022
56d4398
Merge safety workflows
jonhoo Sep 18, 2022
15c1fa2
Catch upcoming deprecations
jonhoo Sep 18, 2022
ea198cc
More concise name for scheduled jobs
jonhoo Sep 18, 2022
441dc27
Allow examples and binaries to require features
jonhoo Sep 18, 2022
b783cb3
Use dependabot, but only for major versions
jonhoo Sep 23, 2022
cf47d4c
ignore is a list
jonhoo Sep 29, 2022
82cbed8
Notify if actions themselves are outdated
jonhoo Dec 10, 2022
c8a7835
Bump codecov/codecov-action from 2 to 3
dependabot[bot] Dec 10, 2022
d6bd5c6
Merge pull request #1 from jonhoo/dependabot/github_actions/codecov/c…
jonhoo Dec 10, 2022
362696a
Move to maintained rust installer
jonhoo Mar 11, 2023
90999e1
Fix install message for msrv
jonhoo Mar 11, 2023
9afb0e1
Get rid of most actions-rs bits
jonhoo Mar 11, 2023
a076ec1
Minimal token permissions
jonhoo Mar 11, 2023
5ea5935
Remove -Zmiri-tag-raw-pointers as it's now default
jonhoo Mar 12, 2023
0d12c82
Unbreak cargo hack for non-libraries (#4)
Tudyx Mar 20, 2023
80a8919
Add action to run doctest. (#3)
Wasabi375 Mar 20, 2023
16a2c29
chore: automatically cancel superseded Actions runs (#5)
SimenB Apr 8, 2023
6332a3a
[sanity] More robust injection of opt-level 1 (#9)
jonhoo Apr 24, 2023
99f108f
Quote MSRV version to avoid float parsing (#11)
jmchacon Aug 13, 2023
c704bcc
Install Openssl for Windows (#12)
chapeupreto Aug 20, 2023
7c327dd
Don't install OpenSSL on Windows by default
jonhoo Aug 20, 2023
deb9fd3
Bump actions/checkout from 3 to 4 (#13)
dependabot[bot] Sep 9, 2023
bfee117
docs: Add documentation based on the youtube video (#10)
joshka Nov 11, 2023
3d6ab95
Nit: Selecting direct minimal versions flag is -Zdirect-minimal-versi…
MathiasPius Nov 11, 2023
60fdfbb
chore: fix typos (#17)
0x61nas Dec 17, 2023
a136915
Remove stray trailing whitespace
jonhoo Dec 17, 2023
f505e09
replace actions-rs/clippy-check with giraffate/clippy-action (#19)
rtkay123 Jan 20, 2024
f8f04ae
Semi-breaking: update codecov action
jonhoo Feb 3, 2024
caa3616
Uniform capitalization
jonhoo Feb 3, 2024
5289775
Add cargo-semver-checks
jonhoo Mar 31, 2024
dcf6883
More intelligent dependabot behaviour
jonhoo Jul 7, 2024
799c99e
Revert "More intelligent dependabot behaviour"
jonhoo Jul 7, 2024
5ed5ed2
documentation check with `cargo-docs-rs` (#23)
carloskiki Aug 18, 2024
c6a8361
fix shell-check (#24)
cospectrum Sep 14, 2024
5aeb4c9
Merge remote-tracking branch 'ci/main' from https://github.com/jonhoo…
Oct 13, 2024
c3d310c
CI only on wasm (our target)
Oct 13, 2024
af86799
Fix CI issues
Oct 19, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .cargo/config.toml
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
[build]
target = "wasm32-wasi"
target = "wasm32-wasip1"
23 changes: 23 additions & 0 deletions .github/DOCS.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
# Github config and workflows

In this folder there is configuration for codecoverage, dependabot, and ci
workflows that check the library more deeply than the default configurations.

This folder can be or was merged using a --allow-unrelated-histories merge
strategy from <https://github.com/jonhoo/rust-ci-conf/> which provides a
reasonably sensible base for writing your own ci on. By using this strategy
the history of the CI repo is included in your repo, and future updates to
the CI can be merged later.

To perform this merge run:

```shell
git remote add ci https://github.com/jonhoo/rust-ci-conf.git
git fetch ci
git merge --allow-unrelated-histories ci/main
```

An overview of the files in this project is available at:
<https://www.youtube.com/watch?v=xUH-4y92jPg&t=491s>, which contains some
rationale for decisions and runs through an example of solving minimal version
and OpenSSL issues.
21 changes: 21 additions & 0 deletions .github/codecov.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
# ref: https://docs.codecov.com/docs/codecovyml-reference
coverage:
# Hold ourselves to a high bar
range: 85..100
round: down
precision: 1
status:
# ref: https://docs.codecov.com/docs/commit-status
project:
default:
# Avoid false negatives
threshold: 1%

# Test files aren't important for coverage
ignore:
- "tests"

# Make comments less noisy
comment:
layout: "files"
require_changes: true
19 changes: 19 additions & 0 deletions .github/dependabot.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
version: 2
updates:
- package-ecosystem: github-actions
directory: /
schedule:
interval: daily
- package-ecosystem: cargo
directory: /
schedule:
interval: daily
ignore:
- dependency-name: "*"
# patch and minor updates don't matter for libraries as consumers of this library build
# with their own lockfile, rather than the version specified in this library's lockfile
# remove this ignore rule if your package has binaries to ensure that the binaries are
# built with the exact set of dependencies and those are up to date.
update-types:
- "version-update:semver-patch"
- "version-update:semver-minor"
134 changes: 134 additions & 0 deletions .github/workflows/check.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,134 @@
# This workflow runs whenever a PR is opened or updated, or a commit is pushed to main. It runs
# several checks:
# - fmt: checks that the code is formatted according to rustfmt
# - clippy: checks that the code does not contain any clippy warnings
# - doc: checks that the code can be documented without errors
# - hack: check combinations of feature flags
# - msrv: check that the msrv specified in the crate is correct
permissions:
contents: read
# This configuration allows maintainers of this repo to create a branch and pull request based on
# the new branch. Restricting the push trigger to the main branch ensures that the PR only gets
# built once.
on:
push:
branches: [main]
pull_request:
# If new code is pushed to a PR branch, then cancel in progress workflows for that PR. Ensures that
# we don't waste CI time, and returns results quicker https://github.com/jonhoo/rust-ci-conf/pull/5
concurrency:
group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }}
cancel-in-progress: true
name: check
jobs:
fmt:
runs-on: ubuntu-latest
name: stable / fmt
steps:
- uses: actions/checkout@v4
with:
submodules: true
- name: Install stable
uses: dtolnay/rust-toolchain@stable
with:
target: wasm32-wasip1
components: rustfmt
- name: cargo fmt --check
run: cargo fmt --check
clippy:
runs-on: ubuntu-latest
name: ${{ matrix.toolchain }} / clippy
permissions:
contents: read
checks: write
strategy:
fail-fast: false
matrix:
# Get early warning of new lints which are regularly introduced in beta channels.
toolchain: [stable, beta]
steps:
- uses: actions/checkout@v4
with:
submodules: true
- name: Install ${{ matrix.toolchain }}
uses: dtolnay/rust-toolchain@master
with:
target: wasm32-wasip1
toolchain: ${{ matrix.toolchain }}
components: clippy
- name: cargo clippy
uses: giraffate/clippy-action@v1
with:
reporter: 'github-pr-check'
github_token: ${{ secrets.GITHUB_TOKEN }}
semver:
runs-on: ubuntu-latest
name: semver
steps:
- uses: actions/checkout@v4
with:
submodules: true
- name: Install stable
uses: dtolnay/rust-toolchain@stable
with:
target: wasm32-wasip1
components: rustfmt
- name: cargo-semver-checks
uses: obi1kenobi/cargo-semver-checks-action@v2
doc:
# run docs generation on nightly rather than stable. This enables features like
# https://doc.rust-lang.org/beta/unstable-book/language-features/doc-cfg.html which allows an
# API be documented as only available in some specific platforms.
runs-on: ubuntu-latest
name: nightly / doc
steps:
- uses: actions/checkout@v4
with:
submodules: true
- name: Install nightly
uses: dtolnay/rust-toolchain@nightly
with:
target: wasm32-wasip1
- name: Install cargo-docs-rs
uses: dtolnay/install@cargo-docs-rs
- name: cargo docs-rs
run: cargo docs-rs
hack:
# cargo-hack checks combinations of feature flags to ensure that features are all additive
# which is required for feature unification
runs-on: ubuntu-latest
name: ubuntu / stable / features
steps:
- uses: actions/checkout@v4
with:
submodules: true
- name: Install stable
uses: dtolnay/rust-toolchain@stable
with:
target: wasm32-wasip1
- name: cargo install cargo-hack
uses: taiki-e/install-action@cargo-hack
# intentionally no target specifier; see https://github.com/jonhoo/rust-ci-conf/pull/4
# --feature-powerset runs for every combination of features
- name: cargo hack
run: cargo hack --feature-powerset check
msrv:
# check that we can build using the minimal rust version that is specified by this crate
runs-on: ubuntu-latest
# we use a matrix here just because env can't be used in job names
# https://docs.github.com/en/actions/learn-github-actions/contexts#context-availability
strategy:
matrix:
msrv: ["1.56.1"] # 2021 edition requires 1.56
name: ubuntu / ${{ matrix.msrv }}
steps:
- uses: actions/checkout@v4
with:
submodules: true
- name: Install ${{ matrix.msrv }}
uses: dtolnay/rust-toolchain@master
with:
target: wasm32-wasip1
toolchain: ${{ matrix.msrv }}
- name: cargo +${{ matrix.msrv }} check
run: cargo check
89 changes: 89 additions & 0 deletions .github/workflows/safety.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,89 @@
# This workflow runs checks for unsafe code. In crates that don't have any unsafe code, this can be
# removed. Runs:
# - miri - detects undefined behavior and memory leaks
# - address sanitizer - detects memory errors
# - leak sanitizer - detects memory leaks
# - loom - Permutation testing for concurrent code https://crates.io/crates/loom
# See check.yml for information about how the concurrency cancellation and workflow triggering works
permissions:
contents: read
on:
push:
branches: [main]
pull_request:
concurrency:
group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }}
cancel-in-progress: true
name: safety
jobs:
sanitizers:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
with:
submodules: true
- name: Install nightly
uses: dtolnay/rust-toolchain@nightly
with:
target: wasm32-wasip1
- run: |
# to get the symbolizer for debug symbol resolution
sudo apt install llvm
# to fix buggy leak analyzer:
# https://github.com/japaric/rust-san#unrealiable-leaksanitizer
# ensure there's a profile.dev section
if ! grep -qE '^[ \t]*[profile.dev]' Cargo.toml; then
echo >> Cargo.toml
echo '[profile.dev]' >> Cargo.toml
fi
# remove pre-existing opt-levels in profile.dev
sed -i '/^\s*\[profile.dev\]/,/^\s*\[/ {/^\s*opt-level/d}' Cargo.toml
# now set opt-level to 1
sed -i '/^\s*\[profile.dev\]/a opt-level = 1' Cargo.toml
cat Cargo.toml
name: Enable debug symbols
- name: cargo test -Zsanitizer=address
# only --lib --tests b/c of https://github.com/rust-lang/rust/issues/53945
run: cargo test --lib --tests --all-features --target x86_64-unknown-linux-gnu
env:
ASAN_OPTIONS: "detect_odr_violation=0:detect_leaks=0"
RUSTFLAGS: "-Z sanitizer=address"
- name: cargo test -Zsanitizer=leak
if: always()
run: cargo test --all-features --target x86_64-unknown-linux-gnu
env:
LSAN_OPTIONS: "suppressions=lsan-suppressions.txt"
RUSTFLAGS: "-Z sanitizer=leak"
miri:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
with:
submodules: true
- run: |
echo "NIGHTLY=nightly-$(curl -s https://rust-lang.github.io/rustup-components-history/x86_64-unknown-linux-gnu/miri)" >> "$GITHUB_ENV"
- name: Install ${{ env.NIGHTLY }}
uses: dtolnay/rust-toolchain@master
with:
target: wasm32-wasip1
toolchain: ${{ env.NIGHTLY }}
components: miri
- name: cargo miri test
run: cargo miri test
env:
MIRIFLAGS: ""
loom:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
with:
submodules: true
- name: Install stable
uses: dtolnay/rust-toolchain@stable
with:
target: wasm32-wasip1
- name: cargo test --test loom
run: cargo test --release --test loom
env:
LOOM_MAX_PREEMPTIONS: 2
RUSTFLAGS: "--cfg loom"
62 changes: 62 additions & 0 deletions .github/workflows/scheduled.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,62 @@
# Run scheduled (rolling) jobs on a nightly basis, as your crate may break independently of any
# given PR. E.g., updates to rust nightly and updates to this crates dependencies. See check.yml for
# information about how the concurrency cancellation and workflow triggering works
permissions:
contents: read
on:
push:
branches: [main]
pull_request:
schedule:
- cron: '7 7 * * *'
concurrency:
group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }}
cancel-in-progress: true
name: rolling
jobs:
# https://twitter.com/mycoliza/status/1571295690063753218
nightly:
runs-on: ubuntu-latest
name: ubuntu / nightly
steps:
- uses: actions/checkout@v4
with:
submodules: true
- name: Install nightly
uses: dtolnay/rust-toolchain@nightly
with:
target: wasm32-wasip1
- name: cargo generate-lockfile
if: hashFiles('Cargo.lock') == ''
run: cargo generate-lockfile
- name: cargo test --locked
run: cargo test --locked --all-features --all-targets
# https://twitter.com/alcuadrado/status/1571291687837732873
update:
# This action checks that updating the dependencies of this crate to the latest available that
# satisfy the versions in Cargo.toml does not break this crate. This is important as consumers
# of this crate will generally use the latest available crates. This is subject to the standard
# Cargo semver rules (i.e cargo does not update to a new major version unless explicitly told
# to).
runs-on: ubuntu-latest
name: ubuntu / beta / updated
# There's no point running this if no Cargo.lock was checked in in the first place, since we'd
# just redo what happened in the regular test job. Unfortunately, hashFiles only works in if on
# steps, so we repeat it.
steps:
- uses: actions/checkout@v4
with:
submodules: true
- name: Install beta
if: hashFiles('Cargo.lock') != ''
uses: dtolnay/rust-toolchain@beta
with:
target: wasm32-wasip1
- name: cargo update
if: hashFiles('Cargo.lock') != ''
run: cargo update
- name: cargo test
if: hashFiles('Cargo.lock') != ''
run: cargo test --locked --all-features --all-targets
env:
RUSTFLAGS: -D deprecated
Loading
Loading