Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add chaos mesh api description and table schema #633

Closed
wants to merge 1 commit into from

Conversation

kerenfi
Copy link
Collaborator

@kerenfi kerenfi commented Sep 14, 2023

Question Answer
Bug fix
New feature
Breaking change
Deprecations
Documentation
Tests added

Related issues: #634

Further information:

@kerenfi kerenfi changed the base branch from master to fb-chaos-mesh-support September 14, 2023 13:42
@kerenfi kerenfi closed this Sep 15, 2023
maximum: 200
default: 100
- in: query
name: template
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't it irrelevant? all are templates

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed - but I closed this MR please see #635

type: boolean
example: true
- in: query
name: exclude
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we need this?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd just a common option in the crud sometimes not to show everything

updated_at:
type: string
format: date-time
description: The date and time that the procesor file was updated.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"procesor file" not relevant in this case

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

kind:
type: string
enum:
- 'dnschaos'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this one is small letters on purpose?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

}

async function insertChaosExperiment(experimentId, experiment, contextId) {
const chaosExperimentModel = client.model('chaos-experiment');
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldnt the function generate the id?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

return _getChaosExperiment(options);
}

async function deleteChaosExperiment(processorId) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be experiment id and not processor id

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

updated_at: {
type: Sequelize.DataTypes.DATE
},
context_id: {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is context id in this case, and why do we need it here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's an header - I think it's like x-zooz.... saw it is added to some resources

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants