Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/skip menu #152

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Feat/skip menu #152

wants to merge 12 commits into from

Conversation

neithanmo
Copy link
Collaborator

@neithanmo neithanmo commented Oct 29, 2024

Feature: Skip Option During Transaction Review

Overview:
Introduces the ability for users to skip any item during the transaction review process and directly navigate to the approval menu. This feature is implemented by invoking the new view_review_init_progressive function:

view_review_init_progressive(tx_getItem, tx_getNumItems, app_sign_eth);
view_review_show(REVIEW_TXN);

User Flow:

  1. Review Message:
    • Item 1
      • Page 1
      • Page 2
      • Page 3
  2. Continue/Skip Menu:
    • Right Button: Continue to the next item.
    • Left Button: Go back to previous item.
    • Both Buttons: Skip to the approval menu.
  3. Review Subsequent Items:
    • Item 2
      • Page 1
    • Continue/Skip Menu
    • Item 3
      • Page 1
      • Page 2
  4. Approval Menu:
    • Final step to approve and sign the transaction.

Compatibility:

  • Supported Targets: All except STAX and FLEX.
  • Purpose: Mimics the review flow used in app-ethereum for EIP-191 personal messages.

Implementation Details:

  • Custom Callback Handler:
    • Created to overcome limitations of the UX_STEP_CB macro.
    • Handles right/left and both button presses.
    • Re-initializes the UI stack to support multiple options on the same screen(nanox/nanos+).

Compilation Flag Consideration:

  • Current Status: Feature is enabled by default when calling view_review_init_progressive.
  • Future Consideration: Evaluate the need for a compilation flag to toggle this feature as needed.

bellow and example:

example_skip

🔗 zboto Link

image

@neithanmo neithanmo marked this pull request as ready for review October 31, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant