Feat/versioned contract #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neithanmo
force-pushed
the
feat/versioned_contract
branch
from
ba484ea
to
b39bf46
Compare
|
Just two minor comments that will be required by Ledger, everything else looks good to me 💪
|
|
Hey @neithanmo. Did the ledger app not work on Stax? What's required to get Stax support? |
|
@neithanmo can you, please, publish the package to npm with this fix? |
Current published version must work without any issue, changes have been done directly to the parser layer and does not required any updates to the npm package. |
|
@neithanmo oh right! Should it be released to ledger store then? I think the latest version there is "v0.23.3" |
neithanmo
added a commit
that referenced
this pull request
Jul 24, 2024
* feat: Add support for versioned smart contracts * bump app version and update snapshots * remove support for stax device * remove linker scripts * update Ledger guidelines enforcer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for versioned smart contract. see #153
🔗 zboto Link