Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alice and bob fix #31

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Alice and bob fix #31

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions AliceAndBobEngine.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,13 +10,28 @@ public class AliceAndBobEngine
String result;

AliceAndBobEngine(){
result = "";
result = "";



}

//HINT: LOOK AT THE TESTS TO SEE WHAT IS EXPECTED FOR DIFFERENT CONDITIONS
public String evaluateAliceOrBob(String input)
{

if (input == "Alice"){
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I detect that this code is problematic. According to the Bad practice (BAD_PRACTICE), ES: Comparison of String objects using == or != (ES_COMPARING_STRINGS_WITH_EQ).
This code compares java.lang.String objects for reference equality using the == or != operators. Unless both strings are either constants in a source file, or have been interned using the String.intern() method, the same string value may be represented by two different String objects. Consider using the equals(Object) method instead.

result = "Hello Alice";
}
else if (input == "Bob")

result = "Hello Bob";
else {

result = "I DON'T KNOW YOU, YOU ARE SCARY";
}



return result;
}
}
42 changes: 26 additions & 16 deletions package.bluej
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,20 +1,23 @@
#BlueJ package file
editor.fx.0.height=0
editor.fx.0.width=0
editor.fx.0.x=0
editor.fx.0.y=0
objectbench.height=101
dependency1.from=AliceAndBobEngineTest
dependency1.to=AliceAndBobEngine
dependency1.type=UsesDependency
editor.fx.0.height=660
editor.fx.0.width=793
editor.fx.0.x=286
editor.fx.0.y=23
objectbench.height=90
objectbench.width=776
package.divider.horizontal=0.6
package.divider.vertical=0.8007380073800738
package.editor.height=427
package.editor.width=674
package.editor.x=181
package.editor.y=109
package.divider.vertical=0.8210332103321033
package.editor.height=438
package.editor.width=682
package.editor.x=781
package.editor.y=54
package.frame.height=600
package.frame.width=800
package.numDependencies=0
package.numTargets=1
package.numDependencies=1
package.numTargets=2
package.showExtends=true
package.showUses=true
project.charset=UTF-8
Expand All @@ -24,9 +27,16 @@ readme.width=47
readme.x=10
readme.y=10
target1.height=50
target1.name=Main
target1.name=AliceAndBobEngineTest
target1.showInterface=false
target1.type=ClassTarget
target1.width=80
target1.type=UnitTestTargetJunit4
target1.width=160
target1.x=70
target1.y=10
target1.y=60
target2.height=50
target2.name=AliceAndBobEngine
target2.showInterface=false
target2.type=ClassTarget
target2.width=130
target2.x=10
target2.y=120